Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

leds: 88pm860x: Fix missing refcount decrement for parent of_node

The driver obtained the reference to parent->of_node but immediately it
was overwritten by reference to child node 'leds'. The of_node_put at
the end of DT parsing function decremented only the child 'leds' so
effectively the reference to parent of_node leaked.

Getting reference to parent->of_node is not needed at all so get rid of
it to fix the reference count.

Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Signed-off-by: Bryan Wu <cooloney@gmail.com>

authored by

Krzysztof Kozlowski and committed by
Bryan Wu
1175d5bc 77dfa771

+2 -3
+2 -3
drivers/leds/leds-88pm860x.c
··· 130 130 struct device_node *nproot, *np; 131 131 int iset = 0; 132 132 133 - nproot = of_node_get(pdev->dev.parent->of_node); 134 - if (!nproot) 133 + if (!pdev->dev.parent->of_node) 135 134 return -ENODEV; 136 - nproot = of_get_child_by_name(nproot, "leds"); 135 + nproot = of_get_child_by_name(pdev->dev.parent->of_node, "leds"); 137 136 if (!nproot) { 138 137 dev_err(&pdev->dev, "failed to find leds node\n"); 139 138 return -ENODEV;