Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

PCI: Use dev_info() rather than dev_err() for ROM validation

On AMD GPUs, we use several mechanisms to fetch the VBIOS ROM depending on
the platform. We try to read the ROM via the ROM BAR and fall back to
other methods in some cases. This leads to spurious error messages from
the PCI ROM code which are harmless in our case. This leads to bugs being
filed, etc. Change these to dev_info() rather than dev_err() to avoid
that.

Link: https://bugzilla.kernel.org/show_bug.cgi?id=198077
Link: https://bugzilla.redhat.com/show_bug.cgi?id=1462438
Link: https://bugs.freedesktop.org/show_bug.cgi?id=98798
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Reviewed-by: Christian König <christian.koenig@amd.com

authored by

Alex Deucher and committed by
Bjorn Helgaas
116a6063 7153884c

+2 -2
+2 -2
drivers/pci/rom.c
··· 92 92 void __iomem *pds; 93 93 /* Standard PCI ROMs start out with these bytes 55 AA */ 94 94 if (readw(image) != 0xAA55) { 95 - dev_err(&pdev->dev, "Invalid PCI ROM header signature: expecting 0xaa55, got %#06x\n", 95 + dev_info(&pdev->dev, "Invalid PCI ROM header signature: expecting 0xaa55, got %#06x\n", 96 96 readw(image)); 97 97 break; 98 98 } 99 99 /* get the PCI data structure and check its "PCIR" signature */ 100 100 pds = image + readw(image + 24); 101 101 if (readl(pds) != 0x52494350) { 102 - dev_err(&pdev->dev, "Invalid PCI ROM data signature: expecting 0x52494350, got %#010x\n", 102 + dev_info(&pdev->dev, "Invalid PCI ROM data signature: expecting 0x52494350, got %#010x\n", 103 103 readl(pds)); 104 104 break; 105 105 }