Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

net: fib: drop include of module.h from fib_notifier.h

Ideally, header files under include/linux shouldn't be adding
includes of other headers, in anticipation of their consumers,
but just the headers needed for the header itself to pass
parsing with CPP.

The module.h is particularly bad in this sense, as it itself does
include a whole bunch of other headers, due to the complexity of
module support.

Since fib_notifier.h is not going into a module struct looking for
specific fields, we can just let it know that module is a struct,
just like about 60 other include/linux headers already do.

Cc: "David S. Miller" <davem@davemloft.net>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

authored by

Paul Gortmaker and committed by
David S. Miller
113e6328 c517796e

+2 -1
+2 -1
include/net/fib_notifier.h
··· 2 2 #define __NET_FIB_NOTIFIER_H 3 3 4 4 #include <linux/types.h> 5 - #include <linux/module.h> 6 5 #include <linux/notifier.h> 7 6 #include <net/net_namespace.h> 7 + 8 + struct module; 8 9 9 10 struct fib_notifier_info { 10 11 struct net *net;