Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

usb: musb: remove some register access wrapper functions

The following wrappers were defined because of Blackfin support. Now
Blackfin support is removed, these wrappers are no longer needed, so
remove them.

musb_write_txfifosz
musb_write_txfifoadd
musb_write_rxfifosz
musb_write_rxfifoadd
musb_write_ulpi_buscontrol
musb_read_txfifosz
musb_read_txfifoadd
musb_read_rxfifosz
musb_read_rxfifoadd
musb_read_ulpi_buscontrol
musb_read_hwvers

Signed-off-by: Bin Liu <b-liu@ti.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

authored by

Bin Liu and committed by
Greg Kroah-Hartman
113ad151 53e1657a

+21 -76
+21 -21
drivers/usb/musb/musb_core.c
··· 1240 1240 /* REVISIT error check: be sure ep0 can both rx and tx ... */ 1241 1241 switch (cfg->style) { 1242 1242 case FIFO_TX: 1243 - musb_write_txfifosz(mbase, c_size); 1244 - musb_write_txfifoadd(mbase, c_off); 1243 + musb_writeb(mbase, MUSB_TXFIFOSZ, c_size); 1244 + musb_writew(mbase, MUSB_TXFIFOADD, c_off); 1245 1245 hw_ep->tx_double_buffered = !!(c_size & MUSB_FIFOSZ_DPB); 1246 1246 hw_ep->max_packet_sz_tx = maxpacket; 1247 1247 break; 1248 1248 case FIFO_RX: 1249 - musb_write_rxfifosz(mbase, c_size); 1250 - musb_write_rxfifoadd(mbase, c_off); 1249 + musb_writeb(mbase, MUSB_RXFIFOSZ, c_size); 1250 + musb_writew(mbase, MUSB_RXFIFOADD, c_off); 1251 1251 hw_ep->rx_double_buffered = !!(c_size & MUSB_FIFOSZ_DPB); 1252 1252 hw_ep->max_packet_sz_rx = maxpacket; 1253 1253 break; 1254 1254 case FIFO_RXTX: 1255 - musb_write_txfifosz(mbase, c_size); 1256 - musb_write_txfifoadd(mbase, c_off); 1255 + musb_writeb(mbase, MUSB_TXFIFOSZ, c_size); 1256 + musb_writew(mbase, MUSB_TXFIFOADD, c_off); 1257 1257 hw_ep->rx_double_buffered = !!(c_size & MUSB_FIFOSZ_DPB); 1258 1258 hw_ep->max_packet_sz_rx = maxpacket; 1259 1259 1260 - musb_write_rxfifosz(mbase, c_size); 1261 - musb_write_rxfifoadd(mbase, c_off); 1260 + musb_writeb(mbase, MUSB_RXFIFOSZ, c_size); 1261 + musb_writew(mbase, MUSB_RXFIFOADD, c_off); 1262 1262 hw_ep->tx_double_buffered = hw_ep->rx_double_buffered; 1263 1263 hw_ep->max_packet_sz_tx = maxpacket; 1264 1264 ··· 1466 1466 } 1467 1467 1468 1468 /* log release info */ 1469 - musb->hwvers = musb_read_hwvers(mbase); 1469 + musb->hwvers = musb_readw(mbase, MUSB_HWVERS); 1470 1470 pr_debug("%s: %sHDRC RTL version %d.%d%s\n", 1471 1471 musb_driver_name, type, MUSB_HWVERS_MAJOR(musb->hwvers), 1472 1472 MUSB_HWVERS_MINOR(musb->hwvers), ··· 2311 2311 2312 2312 /* program PHY to use external vBus if required */ 2313 2313 if (plat->extvbus) { 2314 - u8 busctl = musb_read_ulpi_buscontrol(musb->mregs); 2314 + u8 busctl = musb_readb(musb->mregs, MUSB_ULPI_BUSCONTROL); 2315 2315 busctl |= MUSB_ULPI_USE_EXTVBUS; 2316 - musb_write_ulpi_buscontrol(musb->mregs, busctl); 2316 + musb_writeb(musb->mregs, MUSB_ULPI_BUSCONTROL, busctl); 2317 2317 } 2318 2318 2319 2319 if (musb->xceiv->otg->default_a) { ··· 2482 2482 2483 2483 musb->context.frame = musb_readw(musb_base, MUSB_FRAME); 2484 2484 musb->context.testmode = musb_readb(musb_base, MUSB_TESTMODE); 2485 - musb->context.busctl = musb_read_ulpi_buscontrol(musb->mregs); 2485 + musb->context.busctl = musb_readb(musb_base, MUSB_ULPI_BUSCONTROL); 2486 2486 musb->context.power = musb_readb(musb_base, MUSB_POWER); 2487 2487 musb->context.intrusbe = musb_readb(musb_base, MUSB_INTRUSBE); 2488 2488 musb->context.index = musb_readb(musb_base, MUSB_INDEX); ··· 2511 2511 2512 2512 if (musb->dyn_fifo) { 2513 2513 musb->context.index_regs[i].txfifoadd = 2514 - musb_read_txfifoadd(musb_base); 2514 + musb_readw(musb_base, MUSB_TXFIFOADD); 2515 2515 musb->context.index_regs[i].rxfifoadd = 2516 - musb_read_rxfifoadd(musb_base); 2516 + musb_readw(musb_base, MUSB_RXFIFOADD); 2517 2517 musb->context.index_regs[i].txfifosz = 2518 - musb_read_txfifosz(musb_base); 2518 + musb_readb(musb_base, MUSB_TXFIFOSZ); 2519 2519 musb->context.index_regs[i].rxfifosz = 2520 - musb_read_rxfifosz(musb_base); 2520 + musb_readb(musb_base, MUSB_RXFIFOSZ); 2521 2521 } 2522 2522 2523 2523 musb->context.index_regs[i].txtype = ··· 2554 2554 2555 2555 musb_writew(musb_base, MUSB_FRAME, musb->context.frame); 2556 2556 musb_writeb(musb_base, MUSB_TESTMODE, musb->context.testmode); 2557 - musb_write_ulpi_buscontrol(musb->mregs, musb->context.busctl); 2557 + musb_writeb(musb_base, MUSB_ULPI_BUSCONTROL, musb->context.busctl); 2558 2558 2559 2559 /* Don't affect SUSPENDM/RESUME bits in POWER reg */ 2560 2560 power = musb_readb(musb_base, MUSB_POWER); ··· 2591 2591 musb->context.index_regs[i].rxcsr); 2592 2592 2593 2593 if (musb->dyn_fifo) { 2594 - musb_write_txfifosz(musb_base, 2594 + musb_writeb(musb_base, MUSB_TXFIFOSZ, 2595 2595 musb->context.index_regs[i].txfifosz); 2596 - musb_write_rxfifosz(musb_base, 2596 + musb_writeb(musb_base, MUSB_RXFIFOSZ, 2597 2597 musb->context.index_regs[i].rxfifosz); 2598 - musb_write_txfifoadd(musb_base, 2598 + musb_writew(musb_base, MUSB_TXFIFOADD, 2599 2599 musb->context.index_regs[i].txfifoadd); 2600 - musb_write_rxfifoadd(musb_base, 2600 + musb_writew(musb_base, MUSB_RXFIFOADD, 2601 2601 musb->context.index_regs[i].rxfifoadd); 2602 2602 } 2603 2603
-55
drivers/usb/musb/musb_regs.h
··· 273 273 #define MUSB_RXHUBADDR 0x06 274 274 #define MUSB_RXHUBPORT 0x07 275 275 276 - static inline void musb_write_txfifosz(void __iomem *mbase, u8 c_size) 277 - { 278 - musb_writeb(mbase, MUSB_TXFIFOSZ, c_size); 279 - } 280 - 281 - static inline void musb_write_txfifoadd(void __iomem *mbase, u16 c_off) 282 - { 283 - musb_writew(mbase, MUSB_TXFIFOADD, c_off); 284 - } 285 - 286 - static inline void musb_write_rxfifosz(void __iomem *mbase, u8 c_size) 287 - { 288 - musb_writeb(mbase, MUSB_RXFIFOSZ, c_size); 289 - } 290 - 291 - static inline void musb_write_rxfifoadd(void __iomem *mbase, u16 c_off) 292 - { 293 - musb_writew(mbase, MUSB_RXFIFOADD, c_off); 294 - } 295 - 296 - static inline void musb_write_ulpi_buscontrol(void __iomem *mbase, u8 val) 297 - { 298 - musb_writeb(mbase, MUSB_ULPI_BUSCONTROL, val); 299 - } 300 - 301 - static inline u8 musb_read_txfifosz(void __iomem *mbase) 302 - { 303 - return musb_readb(mbase, MUSB_TXFIFOSZ); 304 - } 305 - 306 - static inline u16 musb_read_txfifoadd(void __iomem *mbase) 307 - { 308 - return musb_readw(mbase, MUSB_TXFIFOADD); 309 - } 310 - 311 - static inline u8 musb_read_rxfifosz(void __iomem *mbase) 312 - { 313 - return musb_readb(mbase, MUSB_RXFIFOSZ); 314 - } 315 - 316 - static inline u16 musb_read_rxfifoadd(void __iomem *mbase) 317 - { 318 - return musb_readw(mbase, MUSB_RXFIFOADD); 319 - } 320 - 321 - static inline u8 musb_read_ulpi_buscontrol(void __iomem *mbase) 322 - { 323 - return musb_readb(mbase, MUSB_ULPI_BUSCONTROL); 324 - } 325 - 326 276 static inline u8 musb_read_configdata(void __iomem *mbase) 327 277 { 328 278 musb_writeb(mbase, MUSB_INDEX, 0); 329 279 return musb_readb(mbase, 0x10 + MUSB_CONFIGDATA); 330 - } 331 - 332 - static inline u16 musb_read_hwvers(void __iomem *mbase) 333 - { 334 - return musb_readw(mbase, MUSB_HWVERS); 335 280 } 336 281 337 282 static inline void musb_write_rxfunaddr(struct musb *musb, u8 epnum,