Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

staging: rtl8188eu: remove cut_mask field from wl_pwr_cfg

We're no longer matching power transitions and commands against a
power cut version mask.

The cut_mask field from struct wl_pwr_cfg can be removed. It was set to
PWR_CUT_ALL_MSK for all remaining commands.

Signed-off-by: Martin Kaiser <martin@kaiser.cx>
Link: https://lore.kernel.org/r/20210718173610.894-10-martin@kaiser.cx
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

authored by

Martin Kaiser and committed by
Greg Kroah-Hartman
1126df74 d950b477

+28 -29
+28 -28
drivers/staging/rtl8188eu/include/pwrseq.h
··· 34 34 * }, 35 35 * comment here 36 36 */ \ 37 - {0x0006, PWR_CUT_ALL_MSK, PWR_CMD_POLLING, BIT(1), BIT(1)}, \ 37 + {0x0006, PWR_CMD_POLLING, BIT(1), BIT(1)}, \ 38 38 /* wait till 0x04[17] = 1 power ready*/ \ 39 - {0x0002, PWR_CUT_ALL_MSK, PWR_CMD_WRITE, BIT(0) | BIT(1), 0}, \ 39 + {0x0002, PWR_CMD_WRITE, BIT(0) | BIT(1), 0}, \ 40 40 /* 0x02[1:0] = 0 reset BB*/ \ 41 - {0x0026, PWR_CUT_ALL_MSK, PWR_CMD_WRITE, BIT(7), BIT(7)}, \ 41 + {0x0026, PWR_CMD_WRITE, BIT(7), BIT(7)}, \ 42 42 /*0x24[23] = 2b'01 schmit trigger */ \ 43 - {0x0005, PWR_CUT_ALL_MSK, PWR_CMD_WRITE, BIT(7), 0}, \ 43 + {0x0005, PWR_CMD_WRITE, BIT(7), 0}, \ 44 44 /* 0x04[15] = 0 disable HWPDN (control by DRV)*/ \ 45 - {0x0005, PWR_CUT_ALL_MSK, PWR_CMD_WRITE, BIT(4) | BIT(3), 0}, \ 45 + {0x0005, PWR_CMD_WRITE, BIT(4) | BIT(3), 0}, \ 46 46 /*0x04[12:11] = 2b'00 disable WL suspend*/ \ 47 - {0x0005, PWR_CUT_ALL_MSK, PWR_CMD_WRITE, BIT(0), BIT(0)}, \ 47 + {0x0005, PWR_CMD_WRITE, BIT(0), BIT(0)}, \ 48 48 /*0x04[8] = 1 polling until return 0*/ \ 49 - {0x0005, PWR_CUT_ALL_MSK, PWR_CMD_POLLING, BIT(0), 0}, \ 49 + {0x0005, PWR_CMD_POLLING, BIT(0), 0}, \ 50 50 /*wait till 0x04[8] = 0*/ \ 51 - {0x0023, PWR_CUT_ALL_MSK, PWR_CMD_WRITE, BIT(4), 0}, \ 51 + {0x0023, PWR_CMD_WRITE, BIT(4), 0}, \ 52 52 /*LDO normal mode*/ 53 53 54 54 #define RTL8188E_TRANS_ACT_TO_CARDEMU \ ··· 57 57 * }, 58 58 * comments here 59 59 */ \ 60 - {0x001F, PWR_CUT_ALL_MSK, PWR_CMD_WRITE, 0xFF, 0}, \ 60 + {0x001F, PWR_CMD_WRITE, 0xFF, 0}, \ 61 61 /*0x1F[7:0] = 0 turn off RF*/ \ 62 - {0x0023, PWR_CUT_ALL_MSK, PWR_CMD_WRITE, BIT(4), BIT(4)}, \ 62 + {0x0023, PWR_CMD_WRITE, BIT(4), BIT(4)}, \ 63 63 /*LDO Sleep mode*/ \ 64 - {0x0005, PWR_CUT_ALL_MSK, PWR_CMD_WRITE, BIT(1), BIT(1)}, \ 64 + {0x0005, PWR_CMD_WRITE, BIT(1), BIT(1)}, \ 65 65 /*0x04[9] = 1 turn off MAC by HW state machine*/ \ 66 - {0x0005, PWR_CUT_ALL_MSK, PWR_CMD_POLLING, BIT(1), 0}, \ 66 + {0x0005, PWR_CMD_POLLING, BIT(1), 0}, \ 67 67 /*wait till 0x04[9] = 0 polling until return 0 to disable*/ 68 68 69 69 #define RTL8188E_TRANS_CARDEMU_TO_CARDDIS \ ··· 72 72 * value }, 73 73 * comments here 74 74 */ \ 75 - {0x0026, PWR_CUT_ALL_MSK, PWR_CMD_WRITE, BIT(7), BIT(7)}, \ 75 + {0x0026, PWR_CMD_WRITE, BIT(7), BIT(7)}, \ 76 76 /*0x24[23] = 2b'01 schmit trigger */ \ 77 - {0x0005, PWR_CUT_ALL_MSK, PWR_CMD_WRITE, BIT(3) | BIT(4), BIT(3)}, \ 77 + {0x0005, PWR_CMD_WRITE, BIT(3) | BIT(4), BIT(3)}, \ 78 78 /*0x04[12:11] = 2b'01 enable WL suspend*/ \ 79 - {0x0007, PWR_CUT_ALL_MSK, PWR_CMD_WRITE, 0xFF, 0}, \ 79 + {0x0007, PWR_CMD_WRITE, 0xFF, 0}, \ 80 80 /* 0x04[31:30] = 2b'10 enable enable bandgap mbias in suspend */\ 81 - {0x0041, PWR_CUT_ALL_MSK, PWR_CMD_WRITE, BIT(4), 0}, \ 81 + {0x0041, PWR_CMD_WRITE, BIT(4), 0}, \ 82 82 /*Clear SIC_EN register 0x40[12] = 1'b0 */ \ 83 - {0xfe10, PWR_CUT_ALL_MSK, PWR_CMD_WRITE, BIT(4), BIT(4)}, \ 83 + {0xfe10, PWR_CMD_WRITE, BIT(4), BIT(4)}, \ 84 84 /*Set USB suspend enable local register 0xfe10[4]=1 */ 85 85 86 86 /* This is used by driver for LPSRadioOff Procedure, not for FW LPS Step */ ··· 90 90 * value }, 91 91 * comments here 92 92 */ \ 93 - {0x0522, PWR_CUT_ALL_MSK, PWR_CMD_WRITE, 0xFF, 0x7F},/*Tx Pause*/ \ 94 - {0x05F8, PWR_CUT_ALL_MSK, PWR_CMD_POLLING, 0xFF, 0}, \ 93 + {0x0522, PWR_CMD_WRITE, 0xFF, 0x7F},/*Tx Pause*/ \ 94 + {0x05F8, PWR_CMD_POLLING, 0xFF, 0}, \ 95 95 /*Should be zero if no packet is transmitting*/ \ 96 - {0x05F9, PWR_CUT_ALL_MSK, PWR_CMD_POLLING, 0xFF, 0}, \ 96 + {0x05F9, PWR_CMD_POLLING, 0xFF, 0}, \ 97 97 /*Should be zero if no packet is transmitting*/ \ 98 - {0x05FA, PWR_CUT_ALL_MSK, PWR_CMD_POLLING, 0xFF, 0}, \ 98 + {0x05FA, PWR_CMD_POLLING, 0xFF, 0}, \ 99 99 /*Should be zero if no packet is transmitting*/ \ 100 - {0x05FB, PWR_CUT_ALL_MSK, PWR_CMD_POLLING, 0xFF, 0}, \ 100 + {0x05FB, PWR_CMD_POLLING, 0xFF, 0}, \ 101 101 /*Should be zero if no packet is transmitting*/ \ 102 - {0x0002, PWR_CUT_ALL_MSK, PWR_CMD_WRITE, BIT(0), 0}, \ 102 + {0x0002, PWR_CMD_WRITE, BIT(0), 0}, \ 103 103 /*CCK and OFDM are disabled,and clock are gated*/ \ 104 - {0x0002, PWR_CUT_ALL_MSK, PWR_CMD_DELAY, 0, PWRSEQ_DELAY_US}, \ 104 + {0x0002, PWR_CMD_DELAY, 0, PWRSEQ_DELAY_US}, \ 105 105 /*Delay 1us*/ \ 106 - {0x0100, PWR_CUT_ALL_MSK, PWR_CMD_WRITE, 0xFF, 0x3F}, \ 106 + {0x0100, PWR_CMD_WRITE, 0xFF, 0x3F}, \ 107 107 /*Reset MAC TRX*/ \ 108 - {0x0101, PWR_CUT_ALL_MSK, PWR_CMD_WRITE, BIT(1), 0}, \ 108 + {0x0101, PWR_CMD_WRITE, BIT(1), 0}, \ 109 109 /*check if removed later*/\ 110 - {0x0553, PWR_CUT_ALL_MSK, PWR_CMD_WRITE, BIT(5), BIT(5)}, \ 110 + {0x0553, PWR_CMD_WRITE, BIT(5), BIT(5)}, \ 111 111 /*Respond TxOK to scheduler*/ 112 112 113 113 #define RTL8188E_TRANS_END \ ··· 116 116 * value }, 117 117 * comments here 118 118 */ \ 119 - {0xFFFF, PWR_CUT_ALL_MSK, PWR_CMD_END, 0, 0}, 119 + {0xFFFF, PWR_CMD_END, 0, 0}, 120 120 121 121 extern struct wl_pwr_cfg rtl8188E_power_on_flow 122 122 [RTL8188E_TRANS_CARDEMU_TO_ACT_STEPS + RTL8188E_TRANS_END_STEPS];
-1
drivers/staging/rtl8188eu/include/pwrseqcmd.h
··· 33 33 34 34 struct wl_pwr_cfg { 35 35 u16 offset; 36 - u8 cut_msk; 37 36 u8 cmd:4; 38 37 u8 msk; 39 38 u8 value;