Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

netfilter: use forward declaration instead of including linux/proc_fs.h

We don't need to pull the full definitions in that file, a simple forward
declaration is enough.

Moreover, include linux/procfs.h from nf_synproxy_core, otherwise this hits a
compilation error due to missing declarations, ie.

net/netfilter/nf_synproxy_core.c: In function ‘synproxy_proc_init’:
net/netfilter/nf_synproxy_core.c:326:2: error: implicit declaration of function ‘proc_create’ [-Werror=implicit-function-declaration]
if (!proc_create("synproxy", S_IRUGO, net->proc_net_stat,
^

Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>

+2 -1
+1 -1
include/net/netns/netfilter.h
··· 1 1 #ifndef __NETNS_NETFILTER_H 2 2 #define __NETNS_NETFILTER_H 3 3 4 - #include <linux/proc_fs.h> 5 4 #include <linux/netfilter.h> 6 5 6 + struct proc_dir_entry; 7 7 struct nf_logger; 8 8 9 9 struct netns_nf {
+1
net/netfilter/nf_synproxy_core.c
··· 11 11 #include <asm/unaligned.h> 12 12 #include <net/tcp.h> 13 13 #include <net/netns/generic.h> 14 + #include <linux/proc_fs.h> 14 15 15 16 #include <linux/netfilter_ipv4/ip_tables.h> 16 17 #include <linux/netfilter/x_tables.h>