Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

mtd: spi-nor: Fix some error codes in cqspi_setup_flash()

We return success or possibly uninitialized values on these error paths
instead of proper error codes.

Fixes: 140623410536 ("mtd: spi-nor: Add driver for Cadence Quad SPI Flash Controller")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Marek Vasut <marex@denx.de>
Reviewed-by: Moritz Fischer <moritz.fischer@ettus.com>
Signed-off-by: Cyrille Pitchen <cyrille.pitchen@atmel.com>

authored by

Dan Carpenter and committed by
Cyrille Pitchen
10ad1d75 193e8714

+3 -1
+3 -1
drivers/mtd/spi-nor/cadence-quadspi.c
··· 1077 1077 1078 1078 /* Get flash device data */ 1079 1079 for_each_available_child_of_node(dev->of_node, np) { 1080 - if (of_property_read_u32(np, "reg", &cs)) { 1080 + ret = of_property_read_u32(np, "reg", &cs); 1081 + if (ret) { 1081 1082 dev_err(dev, "Couldn't determine chip select.\n"); 1082 1083 goto err; 1083 1084 } 1084 1085 1085 1086 if (cs >= CQSPI_MAX_CHIPSELECT) { 1087 + ret = -EINVAL; 1086 1088 dev_err(dev, "Chip select %d out of range.\n", cs); 1087 1089 goto err; 1088 1090 }