Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

crypto: aes - Move key_length in struct crypto_aes_ctx to be the last field

The Intel AES-NI AES acceleration instructions need key_enc, key_dec
in struct crypto_aes_ctx to be 16 byte aligned, it make this easier to
move key_length to be the last one.

Signed-off-by: Huang Ying <ying.huang@intel.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

authored by

Huang Ying and committed by
Herbert Xu
109568e1 8eb2dfac

+10 -6
+3 -3
arch/x86/crypto/aes-i586-asm_32.S
··· 46 46 #define in_blk 16 47 47 48 48 /* offsets in crypto_tfm structure */ 49 - #define klen (crypto_tfm_ctx_offset + 0) 50 - #define ekey (crypto_tfm_ctx_offset + 4) 51 - #define dkey (crypto_tfm_ctx_offset + 244) 49 + #define klen (crypto_tfm_ctx_offset + 480) 50 + #define ekey (crypto_tfm_ctx_offset + 0) 51 + #define dkey (crypto_tfm_ctx_offset + 240) 52 52 53 53 // register mapping for encrypt and decrypt subroutines 54 54
+2 -2
arch/x86/crypto/aes-x86_64-asm_64.S
··· 56 56 .align 8; \ 57 57 FUNC: movq r1,r2; \ 58 58 movq r3,r4; \ 59 - leaq BASE+KEY+48+4(r8),r9; \ 59 + leaq BASE+KEY+48(r8),r9; \ 60 60 movq r10,r11; \ 61 61 movl (r7),r5 ## E; \ 62 62 movl 4(r7),r1 ## E; \ 63 63 movl 8(r7),r6 ## E; \ 64 64 movl 12(r7),r7 ## E; \ 65 - movl BASE+0(r8),r10 ## E; \ 65 + movl BASE+480(r8),r10 ## E; \ 66 66 xorl -48(r9),r5 ## E; \ 67 67 xorl -44(r9),r1 ## E; \ 68 68 xorl -40(r9),r6 ## E; \
+5 -1
include/crypto/aes.h
··· 17 17 #define AES_MAX_KEYLENGTH (15 * 16) 18 18 #define AES_MAX_KEYLENGTH_U32 (AES_MAX_KEYLENGTH / sizeof(u32)) 19 19 20 + /* 21 + * Please ensure that the first two fields are 16-byte aligned 22 + * relative to the start of the structure, i.e., don't move them! 23 + */ 20 24 struct crypto_aes_ctx { 21 - u32 key_length; 22 25 u32 key_enc[AES_MAX_KEYLENGTH_U32]; 23 26 u32 key_dec[AES_MAX_KEYLENGTH_U32]; 27 + u32 key_length; 24 28 }; 25 29 26 30 extern const u32 crypto_ft_tab[4][256];