Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

tools lib traceevent: Do not reassign parg after collapse_tree()

At the end of process_filter(), collapse_tree() was changed to update
the parg parameter, but the reassignment after the call wasn't removed.

What happens is that the "current_op" gets modified and freed and parg
is assigned to the new allocated argument. But after the call to
collapse_tree(), parg is assigned again to the just freed "current_op",
and this causes the tool to crash.

The current_op variable must also be assigned to NULL in case of error,
otherwise it will cause it to be free()ed twice.

Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
Acked-by: Namhyung Kim <namhyung@kernel.org>
Cc: stable@vger.kernel.org # 3.14+
Fixes: 42d6194d133c ("tools lib traceevent: Refactor process_filter()")
Link: http://lkml.kernel.org/r/20160511150936.678c18a1@gandalf.local.home
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

authored by

Steven Rostedt and committed by
Arnaldo Carvalho de Melo
106b816c 49247345

+2 -2
+2 -2
tools/lib/traceevent/parse-filter.c
··· 1164 1164 current_op = current_exp; 1165 1165 1166 1166 ret = collapse_tree(current_op, parg, error_str); 1167 + /* collapse_tree() may free current_op, and updates parg accordingly */ 1168 + current_op = NULL; 1167 1169 if (ret < 0) 1168 1170 goto fail; 1169 - 1170 - *parg = current_op; 1171 1171 1172 1172 free(token); 1173 1173 return 0;