Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

hwrng: geode - fix return value check in mod_init()

In case of error, the function devm_ioremap() returns NULL pointer
not ERR_PTR(). The IS_ERR() test in the return value check should
be replaced with NULL test.

Fixes: 6e9b5e76882c ("hwrng: geode - Migrate to managed API")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

authored by

Wei Yongjun and committed by
Herbert Xu
104a32e8 f7eca278

+2 -2
+2 -2
drivers/char/hw_random/geode-rng.c
··· 95 95 return -ENODEV; 96 96 97 97 mem = devm_ioremap(&pdev->dev, rng_base, 0x58); 98 - if (IS_ERR(mem)) 99 - return PTR_ERR(mem); 98 + if (!mem) 99 + return -ENOMEM; 100 100 geode_rng.priv = (unsigned long)mem; 101 101 102 102 pr_info("AMD Geode RNG detected\n");