Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

staging: iio: adc: Remove unnecessary test from if conditions

Remove unnecessary test condition on ret variable which has been
previously tested and returns its value if the value is non zero.

This fixes the following smatch warnings:
drivers/staging/iio/adc/ad7816.c:299 ad7816_set_oti() warn: we tested
'ret' before and it was 'false'
drivers/staging/iio/adc/ad7816.c:306 ad7816_set_oti() warn: we tested
'ret' before and it was 'false'

Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Reviewed-by: Daniel Baluta <daniel.baluta@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

authored by

Amitoj Kaur Chawla and committed by
Greg Kroah-Hartman
0fd736f9 6a707a9e

+2 -2
+2 -2
drivers/staging/iio/adc/ad7816.c
··· 296 296 dev_err(dev, "Invalid oti channel id %d.\n", chip->channel_id); 297 297 return -EINVAL; 298 298 } else if (chip->channel_id == 0) { 299 - if (ret || value < AD7816_BOUND_VALUE_MIN || 299 + if (value < AD7816_BOUND_VALUE_MIN || 300 300 value > AD7816_BOUND_VALUE_MAX) 301 301 return -EINVAL; 302 302 303 303 data = (u8)(value - AD7816_BOUND_VALUE_MIN + 304 304 AD7816_BOUND_VALUE_BASE); 305 305 } else { 306 - if (ret || value < AD7816_BOUND_VALUE_BASE || value > 255) 306 + if (value < AD7816_BOUND_VALUE_BASE || value > 255) 307 307 return -EINVAL; 308 308 309 309 data = (u8)value;