Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

vdpa_sim: not reset state in vdpasim_queue_ready

vdpasim_queue_ready calls vringh_init_iotlb, which resets split indexes.
But it can be called after setting a ring base with
vdpasim_set_vq_state.

Fix it by stashing them. They're still resetted in vdpasim_vq_reset.

This was discovered and tested live migrating the vdpa_sim_net device.

Fixes: 2c53d0f64c06 ("vdpasim: vDPA device simulator")
Signed-off-by: Eugenio Pérez <eperezma@redhat.com>
Message-Id: <20230118164359.1523760-2-eperezma@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Acked-by: Jason Wang <jasowang@redhat.com>
Tested-by: Lei Yang <leiyang@redhat.com>

authored by

Eugenio Pérez and committed by
Michael S. Tsirkin
0e84f918 ceaa837f

+2
+2
drivers/vdpa/vdpa_sim/vdpa_sim.c
··· 66 66 static void vdpasim_queue_ready(struct vdpasim *vdpasim, unsigned int idx) 67 67 { 68 68 struct vdpasim_virtqueue *vq = &vdpasim->vqs[idx]; 69 + uint16_t last_avail_idx = vq->vring.last_avail_idx; 69 70 70 71 vringh_init_iotlb(&vq->vring, vdpasim->features, vq->num, false, 71 72 (struct vring_desc *)(uintptr_t)vq->desc_addr, ··· 75 74 (struct vring_used *) 76 75 (uintptr_t)vq->device_addr); 77 76 77 + vq->vring.last_avail_idx = last_avail_idx; 78 78 vq->vring.notify = vdpasim_vq_notify; 79 79 } 80 80