Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

drm/gma500: Drop dev->struct_mutex from mmap offset function

Simply forgotten about this when I was doing my general cleansing of
simple gem mmap offset functions. There's nothing but core functions
called here, and they all have their own protection already.

Cc: Patrik Jakobsson <patrik.r.jakobsson@gmail.com>
Acked-by: Patrik Jakobsson <patrik.r.jakobsson@gmail.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Link: http://patchwork.freedesktop.org/patch/msgid/1448271183-20523-20-git-send-email-daniel.vetter@ffwll.ch

+3 -10
+3 -10
drivers/gpu/drm/gma500/gem.c
··· 62 62 int ret = 0; 63 63 struct drm_gem_object *obj; 64 64 65 - mutex_lock(&dev->struct_mutex); 66 - 67 65 /* GEM does all our handle to object mapping */ 68 66 obj = drm_gem_object_lookup(dev, file, handle); 69 - if (obj == NULL) { 70 - ret = -ENOENT; 71 - goto unlock; 72 - } 73 - /* What validation is needed here ? */ 67 + if (obj == NULL) 68 + return -ENOENT; 74 69 75 70 /* Make it mmapable */ 76 71 ret = drm_gem_create_mmap_offset(obj); ··· 73 78 goto out; 74 79 *offset = drm_vma_node_offset_addr(&obj->vma_node); 75 80 out: 76 - drm_gem_object_unreference(obj); 77 - unlock: 78 - mutex_unlock(&dev->struct_mutex); 81 + drm_gem_object_unreference_unlocked(obj); 79 82 return ret; 80 83 } 81 84