Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

gpio: twl4030: Remove error print for devm_add_action_or_reset()

When `devm_add_action_or_reset()` fails, it is due to a failed memory
allocation and will thus return `-ENOMEM`. `dev_err_probe()` doesn't do
anything when error is `-ENOMEM`. Therefore, remove the useless call to
`dev_err_probe()` when `devm_add_action_or_reset()` fails, and just
return the value instead.

Signed-off-by: Waqar Hameed <waqar.hameed@axis.com>
Link: https://lore.kernel.org/r/pndjz3im7te.a.out@axis.com
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

authored by

Waqar Hameed and committed by
Bartosz Golaszewski
0d1e68fb 7ce73ee6

+1 -3
+1 -3
drivers/gpio/gpio-twl4030.c
··· 597 597 598 598 ret = devm_add_action_or_reset(&pdev->dev, gpio_twl4030_power_off_action, d); 599 599 if (ret) 600 - return dev_err_probe(&pdev->dev, ret, 601 - "failed to install power off handler\n"); 602 - 600 + return ret; 603 601 } 604 602 605 603 return 0;