Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

net: ipa: Make the SMEM item ID constant

It can't vary, stop storing the same magic number everywhere.

Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Reviewed-by: Alex Elder <elder@kernel.org>
Link: https://patch.msgid.link/20250512-topic-ipa_smem-v1-1-302679514a0d@oss.qualcomm.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

authored by

Konrad Dybcio and committed by
Jakub Kicinski
0d161eb2 51672a65

+11 -21
-1
drivers/net/ipa/data/ipa_data-v3.1.c
··· 493 493 .local = ipa_mem_local_data, 494 494 .imem_addr = 0x146bd000, 495 495 .imem_size = 0x00002000, 496 - .smem_id = 497, 497 496 .smem_size = 0x00002000, 498 497 }; 499 498
-1
drivers/net/ipa/data/ipa_data-v3.5.1.c
··· 374 374 .local = ipa_mem_local_data, 375 375 .imem_addr = 0x146bd000, 376 376 .imem_size = 0x00002000, 377 - .smem_id = 497, 378 377 .smem_size = 0x00002000, 379 378 }; 380 379
-1
drivers/net/ipa/data/ipa_data-v4.11.c
··· 367 367 .local = ipa_mem_local_data, 368 368 .imem_addr = 0x146a8000, 369 369 .imem_size = 0x00002000, 370 - .smem_id = 497, 371 370 .smem_size = 0x00009000, 372 371 }; 373 372
-1
drivers/net/ipa/data/ipa_data-v4.2.c
··· 340 340 .local = ipa_mem_local_data, 341 341 .imem_addr = 0x146a8000, 342 342 .imem_size = 0x00002000, 343 - .smem_id = 497, 344 343 .smem_size = 0x00002000, 345 344 }; 346 345
-1
drivers/net/ipa/data/ipa_data-v4.5.c
··· 418 418 .local = ipa_mem_local_data, 419 419 .imem_addr = 0x14688000, 420 420 .imem_size = 0x00003000, 421 - .smem_id = 497, 422 421 .smem_size = 0x00009000, 423 422 }; 424 423
-1
drivers/net/ipa/data/ipa_data-v4.7.c
··· 360 360 .local = ipa_mem_local_data, 361 361 .imem_addr = 0x146a8000, 362 362 .imem_size = 0x00002000, 363 - .smem_id = 497, 364 363 .smem_size = 0x00009000, 365 364 }; 366 365
-1
drivers/net/ipa/data/ipa_data-v4.9.c
··· 416 416 .local = ipa_mem_local_data, 417 417 .imem_addr = 0x146bd000, 418 418 .imem_size = 0x00002000, 419 - .smem_id = 497, 420 419 .smem_size = 0x00009000, 421 420 }; 422 421
-1
drivers/net/ipa/data/ipa_data-v5.0.c
··· 442 442 .local = ipa_mem_local_data, 443 443 .imem_addr = 0x14688000, 444 444 .imem_size = 0x00003000, 445 - .smem_id = 497, 446 445 .smem_size = 0x00009000, 447 446 }; 448 447
-1
drivers/net/ipa/data/ipa_data-v5.5.c
··· 448 448 .local = ipa_mem_local_data, 449 449 .imem_addr = 0x14688000, 450 450 .imem_size = 0x00002000, 451 - .smem_id = 497, 452 451 .smem_size = 0x0000b000, 453 452 }; 454 453
-2
drivers/net/ipa/ipa_data.h
··· 180 180 * @local: array of IPA-local memory region descriptors 181 181 * @imem_addr: physical address of IPA region within IMEM 182 182 * @imem_size: size in bytes of IPA IMEM region 183 - * @smem_id: item identifier for IPA region within SMEM memory 184 183 * @smem_size: size in bytes of the IPA SMEM region 185 184 */ 186 185 struct ipa_mem_data { ··· 187 188 const struct ipa_mem *local; 188 189 u32 imem_addr; 189 190 u32 imem_size; 190 - u32 smem_id; 191 191 u32 smem_size; 192 192 }; 193 193
+11 -10
drivers/net/ipa/ipa_mem.c
··· 26 26 /* SMEM host id representing the modem. */ 27 27 #define QCOM_SMEM_HOST_MODEM 1 28 28 29 + #define SMEM_IPA_FILTER_TABLE 497 30 + 29 31 const struct ipa_mem *ipa_mem_find(struct ipa *ipa, enum ipa_mem_id mem_id) 30 32 { 31 33 u32 i; ··· 511 509 /** 512 510 * ipa_smem_init() - Initialize SMEM memory used by the IPA 513 511 * @ipa: IPA pointer 514 - * @item: Item ID of SMEM memory 515 512 * @size: Size (bytes) of SMEM memory region 516 513 * 517 514 * SMEM is a managed block of shared DRAM, from which numbered "items" ··· 524 523 * 525 524 * Note: @size and the item address are is not guaranteed to be page-aligned. 526 525 */ 527 - static int ipa_smem_init(struct ipa *ipa, u32 item, size_t size) 526 + static int ipa_smem_init(struct ipa *ipa, size_t size) 528 527 { 529 528 struct device *dev = ipa->dev; 530 529 struct iommu_domain *domain; ··· 546 545 * The item might have already been allocated, in which case we 547 546 * use it unless the size isn't what we expect. 548 547 */ 549 - ret = qcom_smem_alloc(QCOM_SMEM_HOST_MODEM, item, size); 548 + ret = qcom_smem_alloc(QCOM_SMEM_HOST_MODEM, SMEM_IPA_FILTER_TABLE, size); 550 549 if (ret && ret != -EEXIST) { 551 - dev_err(dev, "error %d allocating size %zu SMEM item %u\n", 552 - ret, size, item); 550 + dev_err(dev, "error %d allocating size %zu SMEM item\n", 551 + ret, size); 553 552 return ret; 554 553 } 555 554 556 555 /* Now get the address of the SMEM memory region */ 557 - virt = qcom_smem_get(QCOM_SMEM_HOST_MODEM, item, &actual); 556 + virt = qcom_smem_get(QCOM_SMEM_HOST_MODEM, SMEM_IPA_FILTER_TABLE, &actual); 558 557 if (IS_ERR(virt)) { 559 558 ret = PTR_ERR(virt); 560 - dev_err(dev, "error %d getting SMEM item %u\n", ret, item); 559 + dev_err(dev, "error %d getting SMEM item\n", ret); 561 560 return ret; 562 561 } 563 562 564 563 /* In case the region was already allocated, verify the size */ 565 564 if (ret && actual != size) { 566 - dev_err(dev, "SMEM item %u has size %zu, expected %zu\n", 567 - item, actual, size); 565 + dev_err(dev, "SMEM item has size %zu, expected %zu\n", 566 + actual, size); 568 567 return -EINVAL; 569 568 } 570 569 ··· 660 659 if (ret) 661 660 goto err_unmap; 662 661 663 - ret = ipa_smem_init(ipa, mem_data->smem_id, mem_data->smem_size); 662 + ret = ipa_smem_init(ipa, mem_data->smem_size); 664 663 if (ret) 665 664 goto err_imem_exit; 666 665