Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

ALSA: ctxfi: pr_* replaced with dev_*

pr_* macros replaced with dev_* as they are more preffered over pr_*.
each file which had pr_* was reviewed manually and replaced with dev_*.
here we have actually used the various snd_card which was added to some
structures of ctxfi via a previous patch of this series.

in the ctvmem.c file we have passed a reference of ct_atc as an
argument to get_vm_block function so that it can be used from
dev_*.

since dev_* will print the device information , so the prefix of
"ctxfi" from the various pr_* were also removed.

Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>

authored by

Sudip Mukherjee and committed by
Takashi Iwai
0cae90a9 a45c4d51

+89 -52
+4 -2
sound/pci/ctxfi/ctamixer.c
··· 258 258 } 259 259 spin_unlock_irqrestore(&mgr->mgr_lock, flags); 260 260 if (err) { 261 - pr_err("ctxfi: Can't meet AMIXER resource request!\n"); 261 + dev_err(mgr->card->dev, 262 + "Can't meet AMIXER resource request!\n"); 262 263 goto error; 263 264 } 264 265 ··· 413 412 } 414 413 spin_unlock_irqrestore(&mgr->mgr_lock, flags); 415 414 if (err) { 416 - pr_err("ctxfi: Can't meet SUM resource request!\n"); 415 + dev_err(mgr->card->dev, 416 + "Can't meet SUM resource request!\n"); 417 417 goto error; 418 418 } 419 419
+16 -11
sound/pci/ctxfi/ctatc.c
··· 186 186 case SNDRV_PCM_FORMAT_FLOAT_LE: 187 187 return SRC_SF_F32; 188 188 default: 189 - pr_err("ctxfi: not recognized snd format is %d\n", 189 + dev_err(card->dev, "not recognized snd format is %d\n", 190 190 snd_format); 191 191 return SRC_SF_S16; 192 192 } ··· 1286 1286 p = snd_pci_quirk_lookup_id(vendor_id, device_id, list); 1287 1287 if (p) { 1288 1288 if (p->value < 0) { 1289 - pr_err("ctxfi: Device %04x:%04x is black-listed\n", 1290 - vendor_id, device_id); 1289 + dev_err(atc->card->dev, 1290 + "Device %04x:%04x is black-listed\n", 1291 + vendor_id, device_id); 1291 1292 return -ENOENT; 1292 1293 } 1293 1294 atc->model = p->value; ··· 1319 1318 err = alsa_dev_funcs[i].create(atc, i, 1320 1319 alsa_dev_funcs[i].public_name); 1321 1320 if (err) { 1322 - pr_err("ctxfi: Creating alsa device %d failed!\n", i); 1321 + dev_err(atc->card->dev, 1322 + "Creating alsa device %d failed!\n", i); 1323 1323 return err; 1324 1324 } 1325 1325 } ··· 1336 1334 1337 1335 err = create_hw_obj(atc->pci, atc->chip_type, atc->model, &hw); 1338 1336 if (err) { 1339 - pr_err("Failed to create hw obj!!!\n"); 1337 + dev_err(atc->card->dev, "Failed to create hw obj!!!\n"); 1340 1338 return err; 1341 1339 } 1342 1340 hw->card = atc->card; ··· 1356 1354 1357 1355 err = rsc_mgr_funcs[i].create(atc->hw, &atc->rsc_mgrs[i]); 1358 1356 if (err) { 1359 - pr_err("ctxfi: Failed to create rsc_mgr %d!!!\n", i); 1357 + dev_err(atc->card->dev, 1358 + "Failed to create rsc_mgr %d!!!\n", i); 1360 1359 return err; 1361 1360 } 1362 1361 } ··· 1404 1401 err = daio_mgr->get_daio(daio_mgr, &da_desc, 1405 1402 (struct daio **)&atc->daios[i]); 1406 1403 if (err) { 1407 - pr_err("ctxfi: Failed to get DAIO resource %d!!!\n", 1404 + dev_err(atc->card->dev, 1405 + "Failed to get DAIO resource %d!!!\n", 1408 1406 i); 1409 1407 return err; 1410 1408 } ··· 1609 1605 /* Do hardware resume. */ 1610 1606 err = atc_hw_resume(atc); 1611 1607 if (err < 0) { 1612 - pr_err("ctxfi: pci_enable_device failed, disabling device\n"); 1608 + dev_err(atc->card->dev, 1609 + "pci_enable_device failed, disabling device\n"); 1613 1610 snd_card_disconnect(atc->card); 1614 1611 return err; 1615 1612 } ··· 1707 1702 /* Find card model */ 1708 1703 err = atc_identify_card(atc, ssid); 1709 1704 if (err < 0) { 1710 - pr_err("ctatc: Card not recognised\n"); 1705 + dev_err(card->dev, "ctatc: Card not recognised\n"); 1711 1706 goto error1; 1712 1707 } 1713 1708 ··· 1723 1718 1724 1719 err = ct_mixer_create(atc, (struct ct_mixer **)&atc->mixer); 1725 1720 if (err) { 1726 - pr_err("ctxfi: Failed to create mixer obj!!!\n"); 1721 + dev_err(card->dev, "Failed to create mixer obj!!!\n"); 1727 1722 goto error1; 1728 1723 } 1729 1724 ··· 1750 1745 1751 1746 error1: 1752 1747 ct_atc_destroy(atc); 1753 - pr_err("ctxfi: Something wrong!!!\n"); 1748 + dev_err(card->dev, "Something wrong!!!\n"); 1754 1749 return err; 1755 1750 }
+2 -1
sound/pci/ctxfi/ctdaio.c
··· 539 539 err = daio_mgr_get_rsc(&mgr->mgr, desc->type); 540 540 spin_unlock_irqrestore(&mgr->mgr_lock, flags); 541 541 if (err) { 542 - pr_err("Can't meet DAIO resource request!\n"); 542 + dev_err(mgr->card->dev, 543 + "Can't meet DAIO resource request!\n"); 543 544 return err; 544 545 } 545 546
+9 -6
sound/pci/ctxfi/cthw20k1.c
··· 1268 1268 1269 1269 /* Set up device page table */ 1270 1270 if ((~0UL) == info->vm_pgt_phys) { 1271 - pr_err("Wrong device page table page address!\n"); 1271 + dev_err(hw->card->dev, 1272 + "Wrong device page table page address!\n"); 1272 1273 return -1; 1273 1274 } 1274 1275 ··· 1328 1327 mdelay(40); 1329 1328 } 1330 1329 if (i >= 3) { 1331 - pr_alert("PLL initialization failed!!!\n"); 1330 + dev_alert(hw->card->dev, "PLL initialization failed!!!\n"); 1332 1331 return -EBUSY; 1333 1332 } 1334 1333 ··· 1352 1351 break; 1353 1352 } 1354 1353 if (!get_field(gctl, GCTL_AID)) { 1355 - pr_alert("Card Auto-init failed!!!\n"); 1354 + dev_alert(hw->card->dev, "Card Auto-init failed!!!\n"); 1356 1355 return -EBUSY; 1357 1356 } 1358 1357 ··· 1912 1911 /* Set DMA transfer mask */ 1913 1912 if (pci_set_dma_mask(pci, CT_XFI_DMA_MASK) < 0 || 1914 1913 pci_set_consistent_dma_mask(pci, CT_XFI_DMA_MASK) < 0) { 1915 - pr_err("architecture does not support PCI busmaster DMA with mask 0x%llx\n", 1916 - CT_XFI_DMA_MASK); 1914 + dev_err(hw->card->dev, 1915 + "architecture does not support PCI busmaster DMA with mask 0x%llx\n", 1916 + CT_XFI_DMA_MASK); 1917 1917 err = -ENXIO; 1918 1918 goto error1; 1919 1919 } ··· 1943 1941 err = request_irq(pci->irq, ct_20k1_interrupt, IRQF_SHARED, 1944 1942 KBUILD_MODNAME, hw); 1945 1943 if (err < 0) { 1946 - pr_err("XFi: Cannot get irq %d\n", pci->irq); 1944 + dev_err(hw->card->dev, 1945 + "XFi: Cannot get irq %d\n", pci->irq); 1947 1946 goto error2; 1948 1947 } 1949 1948 hw->irq = pci->irq;
+15 -9
sound/pci/ctxfi/cthw20k2.c
··· 1187 1187 hw_write_20kx(hw, AUDIO_IO_TX_BLRCLK, 0x21212121); 1188 1188 hw_write_20kx(hw, AUDIO_IO_RX_BLRCLK, 0); 1189 1189 } else { 1190 - pr_alert("ctxfi: ERROR!!! Invalid sampling rate!!!\n"); 1190 + dev_alert(hw->card->dev, 1191 + "ERROR!!! Invalid sampling rate!!!\n"); 1191 1192 return -EINVAL; 1192 1193 } 1193 1194 ··· 1247 1246 1248 1247 /* Set up device page table */ 1249 1248 if ((~0UL) == info->vm_pgt_phys) { 1250 - pr_alert("ctxfi: Wrong device page table page address!!!\n"); 1249 + dev_alert(hw->card->dev, 1250 + "Wrong device page table page address!!!\n"); 1251 1251 return -1; 1252 1252 } 1253 1253 ··· 1353 1351 break; 1354 1352 } 1355 1353 if (i >= 1000) { 1356 - pr_alert("ctxfi: PLL initialization failed!!!\n"); 1354 + dev_alert(hw->card->dev, 1355 + "PLL initialization failed!!!\n"); 1357 1356 return -EBUSY; 1358 1357 } 1359 1358 ··· 1378 1375 break; 1379 1376 } 1380 1377 if (!get_field(gctl, GCTL_AID)) { 1381 - pr_alert("ctxfi: Card Auto-init failed!!!\n"); 1378 + dev_alert(hw->card->dev, "Card Auto-init failed!!!\n"); 1382 1379 return -EBUSY; 1383 1380 } 1384 1381 ··· 1849 1846 /* Initialize I2C */ 1850 1847 err = hw20k2_i2c_init(hw, 0x1A, 1, 1); 1851 1848 if (err < 0) { 1852 - pr_alert("ctxfi: Failure to acquire I2C!!!\n"); 1849 + dev_alert(hw->card->dev, "Failure to acquire I2C!!!\n"); 1853 1850 goto error; 1854 1851 } 1855 1852 ··· 1892 1889 hw20k2_i2c_write(hw, MAKE_WM8775_ADDR(WM8775_MMC, 0x0A), 1893 1890 MAKE_WM8775_DATA(0x0A)); 1894 1891 } else { 1895 - pr_alert("ctxfi: Invalid master sampling rate (msr %d)!!!\n", 1896 - info->msr); 1892 + dev_alert(hw->card->dev, 1893 + "Invalid master sampling rate (msr %d)!!!\n", 1894 + info->msr); 1897 1895 err = -EINVAL; 1898 1896 goto error; 1899 1897 } ··· 2037 2033 /* Set DMA transfer mask */ 2038 2034 if (pci_set_dma_mask(pci, CT_XFI_DMA_MASK) < 0 || 2039 2035 pci_set_consistent_dma_mask(pci, CT_XFI_DMA_MASK) < 0) { 2040 - pr_err("ctxfi: architecture does not support PCI busmaster DMA with mask 0x%llx\n", 2036 + dev_err(hw->card->dev, 2037 + "architecture does not support PCI busmaster DMA with mask 0x%llx\n", 2041 2038 CT_XFI_DMA_MASK); 2042 2039 err = -ENXIO; 2043 2040 goto error1; ··· 2067 2062 err = request_irq(pci->irq, ct_20k2_interrupt, IRQF_SHARED, 2068 2063 KBUILD_MODNAME, hw); 2069 2064 if (err < 0) { 2070 - pr_err("XFi: Cannot get irq %d\n", pci->irq); 2065 + dev_err(hw->card->dev, 2066 + "XFi: Cannot get irq %d\n", pci->irq); 2071 2067 goto error2; 2072 2068 } 2073 2069 hw->irq = pci->irq;
+4 -2
sound/pci/ctxfi/ctmixer.c
··· 854 854 for (i = 0; i < (NUM_CT_SUMS * CHN_NUM); i++) { 855 855 err = sum_mgr->get_sum(sum_mgr, &sum_desc, &sum); 856 856 if (err) { 857 - pr_err("ctxfi:Failed to get sum resources for front output!\n"); 857 + dev_err(mixer->atc->card->dev, 858 + "Failed to get sum resources for front output!\n"); 858 859 break; 859 860 } 860 861 mixer->sums[i] = sum; ··· 869 868 for (i = 0; i < (NUM_CT_AMIXERS * CHN_NUM); i++) { 870 869 err = amixer_mgr->get_amixer(amixer_mgr, &am_desc, &amixer); 871 870 if (err) { 872 - pr_err("ctxfi:Failed to get amixer resources for mixer obj!\n"); 871 + dev_err(mixer->atc->card->dev, 872 + "Failed to get amixer resources for mixer obj!\n"); 873 873 break; 874 874 } 875 875 mixer->amixers[i] = amixer;
+6 -3
sound/pci/ctxfi/ctpcm.c
··· 217 217 err = atc->pcm_playback_prepare(atc, apcm); 218 218 219 219 if (err < 0) { 220 - pr_err("ctxfi: Preparing pcm playback failed!!!\n"); 220 + dev_err(atc->card->dev, 221 + "Preparing pcm playback failed!!!\n"); 221 222 return err; 222 223 } 223 224 ··· 325 324 326 325 err = atc->pcm_capture_prepare(atc, apcm); 327 326 if (err < 0) { 328 - pr_err("ctxfi: Preparing pcm capture failed!!!\n"); 327 + dev_err(atc->card->dev, 328 + "Preparing pcm capture failed!!!\n"); 329 329 return err; 330 330 } 331 331 ··· 437 435 err = snd_pcm_new(atc->card, "ctxfi", device, 438 436 playback_count, capture_count, &pcm); 439 437 if (err < 0) { 440 - pr_err("ctxfi: snd_pcm_new failed!! Err=%d\n", err); 438 + dev_err(atc->card->dev, "snd_pcm_new failed!! Err=%d\n", 439 + err); 441 440 return err; 442 441 } 443 442
+12 -6
sound/pci/ctxfi/ctresource.c
··· 162 162 case DAIO: 163 163 break; 164 164 default: 165 - pr_err("ctxfi: Invalid resource type value %d!\n", type); 165 + dev_err(((struct hw *)hw)->card->dev, 166 + "Invalid resource type value %d!\n", type); 166 167 return -EINVAL; 167 168 } 168 169 169 170 if (err) { 170 - pr_err("ctxfi: Failed to get resource control block!\n"); 171 + dev_err(((struct hw *)hw)->card->dev, 172 + "Failed to get resource control block!\n"); 171 173 return err; 172 174 } 173 175 ··· 190 188 case DAIO: 191 189 break; 192 190 default: 193 - pr_err("ctxfi: Invalid resource type value %d!\n", 191 + dev_err(((struct hw *)rsc->hw)->card->dev, 192 + "Invalid resource type value %d!\n", 194 193 rsc->type); 195 194 break; 196 195 } ··· 233 230 case SUM: 234 231 break; 235 232 default: 236 - pr_err("ctxfi: Invalid resource type value %d!\n", type); 233 + dev_err(hw->card->dev, 234 + "Invalid resource type value %d!\n", type); 237 235 err = -EINVAL; 238 236 goto error; 239 237 } 240 238 241 239 if (err) { 242 - pr_err("ctxfi: Failed to get manager control block!\n"); 240 + dev_err(hw->card->dev, 241 + "Failed to get manager control block!\n"); 243 242 goto error; 244 243 } 245 244 ··· 280 275 case SUM: 281 276 break; 282 277 default: 283 - pr_err("ctxfi: Invalid resource type value %d!\n", 278 + dev_err(((struct hw *)mgr->hw)->card->dev, 279 + "Invalid resource type value %d!\n", 284 280 mgr->type); 285 281 break; 286 282 }
+4 -2
sound/pci/ctxfi/ctsrc.c
··· 431 431 432 432 spin_unlock_irqrestore(&mgr->mgr_lock, flags); 433 433 if (err) { 434 - pr_err("ctxfi: Can't meet SRC resource request!\n"); 434 + dev_err(mgr->card->dev, 435 + "Can't meet SRC resource request!\n"); 435 436 return err; 436 437 } 437 438 ··· 741 740 } 742 741 spin_unlock_irqrestore(&mgr->mgr_lock, flags); 743 742 if (err) { 744 - pr_err("ctxfi: Can't meet SRCIMP resource request!\n"); 743 + dev_err(mgr->card->dev, 744 + "Can't meet SRCIMP resource request!\n"); 745 745 goto error1; 746 746 } 747 747
+8 -4
sound/pci/ctxfi/ctvmem.c
··· 16 16 */ 17 17 18 18 #include "ctvmem.h" 19 + #include "ctatc.h" 19 20 #include <linux/slab.h> 20 21 #include <linux/mm.h> 21 22 #include <linux/io.h> ··· 30 29 * @size must be page aligned. 31 30 * */ 32 31 static struct ct_vm_block * 33 - get_vm_block(struct ct_vm *vm, unsigned int size) 32 + get_vm_block(struct ct_vm *vm, unsigned int size, struct ct_atc *atc) 34 33 { 35 34 struct ct_vm_block *block = NULL, *entry; 36 35 struct list_head *pos; 37 36 38 37 size = CT_PAGE_ALIGN(size); 39 38 if (size > vm->size) { 40 - pr_err("ctxfi: Fail! No sufficient device virtual memory space available!\n"); 39 + dev_err(atc->card->dev, 40 + "Fail! No sufficient device virtual memory space available!\n"); 41 41 return NULL; 42 42 } 43 43 ··· 130 128 unsigned int pte_start; 131 129 unsigned i, pages; 132 130 unsigned long *ptp; 131 + struct ct_atc *atc = snd_pcm_substream_chip(substream); 133 132 134 - block = get_vm_block(vm, size); 133 + block = get_vm_block(vm, size, atc); 135 134 if (block == NULL) { 136 - pr_err("ctxfi: No virtual memory block that is big enough to allocate!\n"); 135 + dev_err(atc->card->dev, 136 + "No virtual memory block that is big enough to allocate!\n"); 137 137 return NULL; 138 138 } 139 139
+9 -6
sound/pci/ctxfi/xfi.c
··· 76 76 if (err) 77 77 return err; 78 78 if ((reference_rate != 48000) && (reference_rate != 44100)) { 79 - pr_err("ctxfi: Invalid reference_rate value %u!!!\n", 80 - reference_rate); 81 - pr_err("ctxfi: The valid values for reference_rate are 48000 and 44100, Value 48000 is assumed.\n"); 79 + dev_err(card->dev, 80 + "Invalid reference_rate value %u!!!\n", 81 + reference_rate); 82 + dev_err(card->dev, 83 + "The valid values for reference_rate are 48000 and 44100, Value 48000 is assumed.\n"); 82 84 reference_rate = 48000; 83 85 } 84 86 if ((multiple != 1) && (multiple != 2) && (multiple != 4)) { 85 - pr_err("ctxfi: Invalid multiple value %u!!!\n", 86 - multiple); 87 - pr_err("ctxfi: The valid values for multiple are 1, 2 and 4, Value 2 is assumed.\n"); 87 + dev_err(card->dev, "Invalid multiple value %u!!!\n", 88 + multiple); 89 + dev_err(card->dev, 90 + "The valid values for multiple are 1, 2 and 4, Value 2 is assumed.\n"); 88 91 multiple = 2; 89 92 } 90 93 err = ct_atc_create(card, pci, reference_rate, multiple,