Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

Staging: w35und: kill WBDEBUG and remove common.h header file

The only remaining thing in common.h header file is the WBDEBUG() macro which
is unconditionally defined as printk(). Kill the macro and remove the header
file.

Signed-off-by: Pekka Enberg <penberg@cs.helsinki.fi>
Acked-by: Pavel Machek <pavel@suse.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

authored by

Pekka Enberg and committed by
Greg Kroah-Hartman
0c59dbaa 132e755a

+31 -57
-23
drivers/staging/winbond/common.h
··· 1 - // 2 - // common.h 3 - // 4 - // This file contains the OS dependant definition and function. 5 - // Every OS has this file individual. 6 - // 7 - #ifndef COMMON_DEF 8 - #define COMMON_DEF 9 - 10 - //#define DEBUG_ENABLED 1 11 - 12 - //================================================================================================== 13 - // Common function definition 14 - //================================================================================================== 15 - #define DEBUG_ENABLED 16 - #ifdef DEBUG_ENABLED 17 - #define WBDEBUG( _M ) printk _M 18 - #else 19 - #define WBDEBUG( _M ) 0 20 - #endif 21 - 22 - #endif // COMMON_DEF 23 -
+4 -4
drivers/staging/winbond/mds.c
··· 374 374 375 375 pDes->TxRate = ctmp1; 376 376 #ifdef _PE_TX_DUMP_ 377 - WBDEBUG(("Tx rate =%x\n", ctmp1)); 377 + printk("Tx rate =%x\n", ctmp1); 378 378 #endif 379 379 380 380 pT01->T01_modulation_type = (ctmp1%3) ? 0 : 1; ··· 442 442 FillIndex = pMds->TxFillIndex; 443 443 if (pMds->TxOwner[FillIndex]) { // Is owned by software 0:Yes 1:No 444 444 #ifdef _PE_TX_DUMP_ 445 - WBDEBUG(("[Mds_Tx] Tx Owner is H/W.\n")); 445 + printk("[Mds_Tx] Tx Owner is H/W.\n"); 446 446 #endif 447 447 break; 448 448 } ··· 488 488 // For speed up Key setting 489 489 if (pTxDes->EapFix) { 490 490 #ifdef _PE_TX_DUMP_ 491 - WBDEBUG(("35: EPA 4th frame detected. Size = %d\n", PacketSize)); 491 + printk("35: EPA 4th frame detected. Size = %d\n", PacketSize); 492 492 #endif 493 493 pHwData->IsKeyPreSet = 1; 494 494 } ··· 585 585 else 586 586 pHwData->tx_retry_count[7] += RetryCount; 587 587 #ifdef _PE_STATE_DUMP_ 588 - WBDEBUG(("dto_tx_retry_count =%d\n", pHwData->dto_tx_retry_count)); 588 + printk("dto_tx_retry_count =%d\n", pHwData->dto_tx_retry_count); 589 589 #endif 590 590 MTO_SetTxCount(adapter, TxRate, RetryCount); 591 591 }
-1
drivers/staging/winbond/mto.c
··· 83 83 void MTO_Init(MTO_FUNC_INPUT) 84 84 { 85 85 int i; 86 - //WBDEBUG(("[MTO] -> MTO_Init()\n")); 87 86 //[WKCHEN]pMTOcore_data = pcore_data; 88 87 // 20040510 Turbo add for global variable 89 88 MTO_TMR_CNT() = 0;
+9 -9
drivers/staging/winbond/reg.c
··· 1114 1114 //Start to fill RF parameters, PLL_ON should be pulled low. 1115 1115 Wb35Reg_WriteSync( pHwData, 0x03dc, 0x00000000 ); 1116 1116 #ifdef _PE_STATE_DUMP_ 1117 - WBDEBUG(("* PLL_ON low\n")); 1117 + printk("* PLL_ON low\n"); 1118 1118 #endif 1119 1119 1120 1120 number = sizeof(al7230_rf_data_24)/sizeof(al7230_rf_data_24[0]); ··· 1223 1223 //pulled high 1224 1224 Wb35Reg_WriteSync( pHwData, 0x03dc, 0x00000080 ); 1225 1225 #ifdef _PE_STATE_DUMP_ 1226 - WBDEBUG(("* PLL_ON high\n")); 1226 + printk("* PLL_ON high\n"); 1227 1227 #endif 1228 1228 1229 1229 //2.4GHz ··· 1243 1243 //5GHz 1244 1244 Wb35Reg_WriteSync( pHwData, 0x03dc, 0x00000000 ); 1245 1245 #ifdef _PE_STATE_DUMP_ 1246 - WBDEBUG(("* PLL_ON low\n")); 1246 + printk("* PLL_ON low\n"); 1247 1247 #endif 1248 1248 1249 1249 number = sizeof(al7230_rf_data_50)/sizeof(al7230_rf_data_50[0]); ··· 1255 1255 1256 1256 Wb35Reg_WriteSync( pHwData, 0x03dc, 0x00000080 ); 1257 1257 #ifdef _PE_STATE_DUMP_ 1258 - WBDEBUG(("* PLL_ON high\n")); 1258 + printk("* PLL_ON high\n"); 1259 1259 #endif 1260 1260 1261 1261 //ltmp = (1 << 31) | (0 << 30) | (24 << 24) | 0x12BACF; ··· 1271 1271 msleep(5); 1272 1272 1273 1273 //Wb35Reg_WriteSync( pHwData, 0x03dc, 0x00000080 ); 1274 - //WBDEBUG(("* PLL_ON high\n")); 1274 + //printk("* PLL_ON high\n"); 1275 1275 break; 1276 1276 1277 1277 case RF_WB_242: ··· 2011 2011 2012 2012 //Start to fill RF parameters, PLL_ON should be pulled low. 2013 2013 //Wb35Reg_Write( pHwData, 0x03dc, 0x00000000 ); 2014 - //WBDEBUG(("* PLL_ON low\n")); 2014 + //printk("* PLL_ON low\n"); 2015 2015 2016 2016 //Channel independent registers 2017 2017 if( Channel.band != pHwData->band) ··· 2036 2036 // Write to register. number must less and equal than 16 2037 2037 Wb35Reg_BurstWrite( pHwData, 0x0864, pltmp, number, NO_INCREMENT ); 2038 2038 #ifdef _PE_STATE_DUMP_ 2039 - WBDEBUG(("Band changed\n")); 2039 + printk("Band changed\n"); 2040 2040 #endif 2041 2041 } 2042 2042 ··· 2611 2611 } 2612 2612 2613 2613 #ifdef _PE_STATE_DUMP_ 2614 - WBDEBUG((" TxVgaFor24 : \n")); 2614 + printk(" TxVgaFor24 : \n"); 2615 2615 DataDmp((u8 *)pHwData->TxVgaFor24, 14 ,0); 2616 - WBDEBUG((" TxVgaFor50 : \n")); 2616 + printk(" TxVgaFor50 : \n"); 2617 2617 DataDmp((u8 *)pHwData->TxVgaFor50, 70 ,0); 2618 2618 #endif 2619 2619 }
+5 -5
drivers/staging/winbond/wb35reg.c
··· 149 149 150 150 if (ret < 0) { 151 151 #ifdef _PE_REG_DUMP_ 152 - WBDEBUG(("EP0 Write register usb message sending error\n")); 152 + printk("EP0 Write register usb message sending error\n"); 153 153 #endif 154 154 155 155 pHwData->SurpriseRemove = 1; // 20060704.2 ··· 316 316 317 317 if (ret < 0) { 318 318 #ifdef _PE_REG_DUMP_ 319 - WBDEBUG(("EP0 Read register usb message sending error\n")); 319 + printk("EP0 Read register usb message sending error\n"); 320 320 #endif 321 321 322 322 pHwData->SurpriseRemove = 1; // 20060704.2 ··· 441 441 442 442 if (ret < 0) { 443 443 #ifdef _PE_REG_DUMP_ 444 - WBDEBUG(("EP0 Irp sending error\n")); 444 + printk("EP0 Irp sending error\n"); 445 445 #endif 446 446 goto cleanup; 447 447 } ··· 480 480 481 481 if (reg->EP0VM_status) { 482 482 #ifdef _PE_REG_DUMP_ 483 - WBDEBUG(("EP0 IoCompleteRoutine return error\n")); 483 + printk("EP0 IoCompleteRoutine return error\n"); 484 484 #endif 485 485 reg->EP0vm_state = VM_STOP; 486 486 pHwData->SurpriseRemove = 1; ··· 529 529 kfree(reg_queue); 530 530 } else { 531 531 #ifdef _PE_REG_DUMP_ 532 - WBDEBUG(("EP0 queue release error\n")); 532 + printk("EP0 queue release error\n"); 533 533 #endif 534 534 } 535 535 spin_lock_irq( &reg->EP0VM_spin_lock );
+5 -5
drivers/staging/winbond/wb35rx.c
··· 118 118 // Basic check for Rx length. Is length valid? 119 119 if (PacketSize > MAX_PACKET_SIZE) { 120 120 #ifdef _PE_RX_DUMP_ 121 - WBDEBUG(("Serious ERROR : Rx data size too long, size =%d\n", PacketSize)); 121 + printk("Serious ERROR : Rx data size too long, size =%d\n", PacketSize); 122 122 #endif 123 123 124 124 pWb35Rx->EP3vm_state = VM_STOP; ··· 194 194 // The URB is completed, check the result 195 195 if (pWb35Rx->EP3VM_status != 0) { 196 196 #ifdef _PE_USB_STATE_DUMP_ 197 - WBDEBUG(("EP3 IoCompleteRoutine return error\n")); 197 + printk("EP3 IoCompleteRoutine return error\n"); 198 198 #endif 199 199 pWb35Rx->EP3vm_state = VM_STOP; 200 200 goto error; ··· 259 259 if (!pWb35Rx->RxOwner[RxBufferId]) { 260 260 // It's impossible to run here. 261 261 #ifdef _PE_RX_DUMP_ 262 - WBDEBUG(("Rx driver fifo unavailable\n")); 262 + printk("Rx driver fifo unavailable\n"); 263 263 #endif 264 264 goto error; 265 265 } ··· 348 348 if (pWb35Rx->EP3vm_state == VM_RUNNING) { 349 349 usb_unlink_urb( pWb35Rx->RxUrb ); // Only use unlink, let Wb35Rx_destroy to free them 350 350 #ifdef _PE_RX_DUMP_ 351 - WBDEBUG(("EP3 Rx stop\n")); 351 + printk("EP3 Rx stop\n"); 352 352 #endif 353 353 } 354 354 } ··· 366 366 if (pWb35Rx->RxUrb) 367 367 usb_free_urb( pWb35Rx->RxUrb ); 368 368 #ifdef _PE_RX_DUMP_ 369 - WBDEBUG(("Wb35Rx_destroy OK\n")); 369 + printk("Wb35Rx_destroy OK\n"); 370 370 #endif 371 371 } 372 372
+5 -5
drivers/staging/winbond/wb35tx.c
··· 153 153 if (pWb35Tx->EP2vm_state == VM_RUNNING) 154 154 usb_unlink_urb( pWb35Tx->Tx2Urb ); // Only use unlink, let Wb35Tx_destrot to free them 155 155 #ifdef _PE_TX_DUMP_ 156 - WBDEBUG(("EP2 Tx stop\n")); 156 + printk("EP2 Tx stop\n"); 157 157 #endif 158 158 159 159 // Trying to canceling the Irp of EP4 160 160 if (pWb35Tx->EP4vm_state == VM_RUNNING) 161 161 usb_unlink_urb( pWb35Tx->Tx4Urb ); // Only use unlink, let Wb35Tx_destrot to free them 162 162 #ifdef _PE_TX_DUMP_ 163 - WBDEBUG(("EP4 Tx stop\n")); 163 + printk("EP4 Tx stop\n"); 164 164 #endif 165 165 } 166 166 ··· 182 182 usb_free_urb( pWb35Tx->Tx2Urb ); 183 183 184 184 #ifdef _PE_TX_DUMP_ 185 - WBDEBUG(("Wb35Tx_destroy OK\n")); 185 + printk("Wb35Tx_destroy OK\n"); 186 186 #endif 187 187 } 188 188 ··· 229 229 230 230 //The Urb is completed, check the result 231 231 if (pWb35Tx->EP2VM_status != 0) { 232 - WBDEBUG(("EP2 IoCompleteRoutine return error\n")); 232 + printk("EP2 IoCompleteRoutine return error\n"); 233 233 pWb35Tx->EP2vm_state= VM_STOP; 234 234 goto error; 235 235 } ··· 279 279 280 280 if (retv < 0) { 281 281 #ifdef _PE_TX_DUMP_ 282 - WBDEBUG(("EP2 Tx Irp sending error\n")); 282 + printk("EP2 Tx Irp sending error\n"); 283 283 #endif 284 284 goto error; 285 285 }
+1 -1
drivers/staging/winbond/wbhal.c
··· 396 396 pHwData->Channel = channel.ChanNo; 397 397 pHwData->band = channel.band; 398 398 #ifdef _PE_STATE_DUMP_ 399 - WBDEBUG(("Set channel is %d, band =%d\n", pHwData->Channel, pHwData->band)); 399 + printk("Set channel is %d, band =%d\n", pHwData->Channel, pHwData->band); 400 400 #endif 401 401 reg->M28_MacControl &= ~0xff; // Clean channel information field 402 402 reg->M28_MacControl |= channel.ChanNo;
-2
drivers/staging/winbond/wbhal_s.h
··· 4 4 #include <linux/types.h> 5 5 #include <linux/if_ether.h> /* for ETH_ALEN */ 6 6 7 - #include "common.h" 8 - 9 7 //[20040722 WK] 10 8 #define HAL_LED_SET_MASK 0x001c //20060901 Extend 11 9 #define HAL_LED_SET_SHIFT 2
+2 -2
drivers/staging/winbond/wbusb.c
··· 277 277 //get current antenna 278 278 priv->sLocalPara.bAntennaNo = hal_get_antenna_number(pHwData); 279 279 #ifdef _PE_STATE_DUMP_ 280 - WBDEBUG(("Driver init, antenna no = %d\n", psLOCAL->bAntennaNo)); 280 + printk("Driver init, antenna no = %d\n", psLOCAL->bAntennaNo); 281 281 #endif 282 282 hal_get_hw_radio_off( pHwData ); 283 283 ··· 404 404 // Turn off Rx and Tx hardware ability 405 405 hal_stop( &adapter->sHwData ); 406 406 #ifdef _PE_USB_INI_DUMP_ 407 - WBDEBUG(("[w35und] Hal_stop O.K.\n")); 407 + printk("[w35und] Hal_stop O.K.\n"); 408 408 #endif 409 409 msleep(100);// Waiting Irp completed 410 410