Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

leds: aat1290: Add missing of_node_put

The refcount of device_node increases after of_get_next_available_child()
is called. Make sure it is decremented also in case of DT parsing error.

Signed-off-by: Jacek Anaszewski <j.anaszewski@samsung.com>
Cc: Rob Herring <robh@kernel.org>
Cc: Sakari Ailus <sakari.ailus@linux.intel.com>

+5 -4
+5 -4
drivers/leds/leds-aat1290.c
··· 275 275 if (ret < 0) { 276 276 dev_err(dev, 277 277 "flash-max-microamp DT property missing\n"); 278 - return ret; 278 + goto err_parse_dt; 279 279 } 280 280 281 281 ret = of_property_read_u32(child_node, "flash-max-timeout-us", ··· 283 283 if (ret < 0) { 284 284 dev_err(dev, 285 285 "flash-max-timeout-us DT property missing\n"); 286 - return ret; 286 + goto err_parse_dt; 287 287 } 288 288 289 - of_node_put(child_node); 290 - 291 289 *sub_node = child_node; 290 + 291 + err_parse_dt: 292 + of_node_put(child_node); 292 293 293 294 return ret; 294 295 }