Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

selftests: arg_parsing: Ensure data is flushed to disk before reading.

test_parse_test_list_file writes some data to
/tmp/bpf_arg_parsing_test.XXXXXX and parse_test_list_file() will read
the data back. However, after writing data to that file, we forget to
call fsync() and it's causing testing failure in my laptop. This patch
helps fix it by adding the missing fsync() call.

Fixes: 64276f01dce8 ("selftests/bpf: Test_progs can read test lists from file")
Signed-off-by: Xing Guo <higuoxing@gmail.com>
Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
Link: https://lore.kernel.org/bpf/20251016035330.3217145-1-higuoxing@gmail.com

authored by

Xing Guo and committed by
Andrii Nakryiko
0c1999ed 5fb750e8

+3
+3
tools/testing/selftests/bpf/prog_tests/arg_parsing.c
··· 144 144 if (!ASSERT_OK(ferror(fp), "prepare tmp")) 145 145 goto out_fclose; 146 146 147 + if (!ASSERT_OK(fsync(fileno(fp)), "fsync tmp")) 148 + goto out_fclose; 149 + 147 150 init_test_filter_set(&set); 148 151 149 152 if (!ASSERT_OK(parse_test_list_file(tmpfile, &set, true), "parse file"))