Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

[WATCHDOG] Coding style - Indentation - part 2

This brings the watchdog drivers into line with coding style.
This patch takes cares of the indentation as described in chapter 1.
Main changes:
* Re-structure the ioctl switch call for all drivers as follows:
switch (cmd) {
case WDIOC_GETSUPPORT:
case WDIOC_GETSTATUS:
case WDIOC_GETBOOTSTATUS:
case WDIOC_GETTEMP:
case WDIOC_SETOPTIONS:
case WDIOC_KEEPALIVE:
case WDIOC_SETTIMEOUT:
case WDIOC_GETTIMEOUT:
case WDIOC_GETTIMELEFT:
default:
}

This to make the migration from the drivers to the uniform watchdog
device driver easier in the future.

Signed-off-by: Wim Van Sebroeck <wim@iguana.be>

+429 -429
+7 -7
drivers/watchdog/acquirewdt.c
··· 164 164 case WDIOC_GETBOOTSTATUS: 165 165 return put_user(0, p); 166 166 167 - case WDIOC_KEEPALIVE: 168 - acq_keepalive(); 169 - return 0; 170 - 171 - case WDIOC_GETTIMEOUT: 172 - return put_user(WATCHDOG_HEARTBEAT, p); 173 - 174 167 case WDIOC_SETOPTIONS: 175 168 { 176 169 if (get_user(options, p)) ··· 178 185 } 179 186 return retval; 180 187 } 188 + case WDIOC_KEEPALIVE: 189 + acq_keepalive(); 190 + return 0; 191 + 192 + case WDIOC_GETTIMEOUT: 193 + return put_user(WATCHDOG_HEARTBEAT, p); 194 + 181 195 default: 182 196 return -ENOTTY; 183 197 }
+13 -13
drivers/watchdog/advantechwdt.c
··· 152 152 case WDIOC_GETBOOTSTATUS: 153 153 return put_user(0, p); 154 154 155 - case WDIOC_KEEPALIVE: 156 - advwdt_ping(); 157 - break; 158 - 159 - case WDIOC_SETTIMEOUT: 160 - if (get_user(new_timeout, p)) 161 - return -EFAULT; 162 - if (advwdt_set_heartbeat(new_timeout)) 163 - return -EINVAL; 164 - advwdt_ping(); 165 - /* Fall */ 166 - case WDIOC_GETTIMEOUT: 167 - return put_user(timeout, p); 168 155 case WDIOC_SETOPTIONS: 169 156 { 170 157 int options, retval = -EINVAL; ··· 168 181 } 169 182 return retval; 170 183 } 184 + case WDIOC_KEEPALIVE: 185 + advwdt_ping(); 186 + break; 187 + 188 + case WDIOC_SETTIMEOUT: 189 + if (get_user(new_timeout, p)) 190 + return -EFAULT; 191 + if (advwdt_set_heartbeat(new_timeout)) 192 + return -EINVAL; 193 + advwdt_ping(); 194 + /* Fall */ 195 + case WDIOC_GETTIMEOUT: 196 + return put_user(timeout, p); 171 197 default: 172 198 return -ENOTTY; 173 199 }
+3 -3
drivers/watchdog/alim1535_wdt.c
··· 195 195 case WDIOC_GETSTATUS: 196 196 case WDIOC_GETBOOTSTATUS: 197 197 return put_user(0, p); 198 - case WDIOC_KEEPALIVE: 199 - ali_keepalive(); 200 - return 0; 201 198 case WDIOC_SETOPTIONS: 202 199 { 203 200 int new_options, retval = -EINVAL; ··· 211 214 } 212 215 return retval; 213 216 } 217 + case WDIOC_KEEPALIVE: 218 + ali_keepalive(); 219 + return 0; 214 220 case WDIOC_SETTIMEOUT: 215 221 { 216 222 int new_timeout;
+3 -3
drivers/watchdog/alim7101_wdt.c
··· 251 251 case WDIOC_GETSTATUS: 252 252 case WDIOC_GETBOOTSTATUS: 253 253 return put_user(0, p); 254 - case WDIOC_KEEPALIVE: 255 - wdt_keepalive(); 256 - return 0; 257 254 case WDIOC_SETOPTIONS: 258 255 { 259 256 int new_options, retval = -EINVAL; ··· 267 270 } 268 271 return retval; 269 272 } 273 + case WDIOC_KEEPALIVE: 274 + wdt_keepalive(); 275 + return 0; 270 276 case WDIOC_SETTIMEOUT: 271 277 { 272 278 int new_timeout;
+2 -2
drivers/watchdog/ar7_wdt.c
··· 251 251 int new_margin; 252 252 253 253 switch (cmd) { 254 - default: 255 - return -ENOTTY; 256 254 case WDIOC_GETSUPPORT: 257 255 if (copy_to_user((struct watchdog_info *)arg, &ident, 258 256 sizeof(ident))) ··· 279 281 if (put_user(margin, (int *)arg)) 280 282 return -EFAULT; 281 283 return 0; 284 + default: 285 + return -ENOTTY; 282 286 } 283 287 } 284 288
+17 -17
drivers/watchdog/at32ap700x_wdt.c
··· 221 221 int __user *p = argp; 222 222 223 223 switch (cmd) { 224 - case WDIOC_KEEPALIVE: 225 - at32_wdt_pat(); 226 - ret = 0; 227 - break; 228 224 case WDIOC_GETSUPPORT: 229 225 ret = copy_to_user(argp, &at32_wdt_info, 230 226 sizeof(at32_wdt_info)) ? -EFAULT : 0; 231 - break; 232 - case WDIOC_SETTIMEOUT: 233 - ret = get_user(time, p); 234 - if (ret) 235 - break; 236 - ret = at32_wdt_settimeout(time); 237 - if (ret) 238 - break; 239 - /* Enable new time value */ 240 - at32_wdt_start(); 241 - /* fall through */ 242 - case WDIOC_GETTIMEOUT: 243 - ret = put_user(wdt->timeout, p); 244 227 break; 245 228 case WDIOC_GETSTATUS: 246 229 ret = put_user(0, p); ··· 240 257 if (time & WDIOS_ENABLECARD) 241 258 at32_wdt_start(); 242 259 ret = 0; 260 + break; 261 + case WDIOC_KEEPALIVE: 262 + at32_wdt_pat(); 263 + ret = 0; 264 + break; 265 + case WDIOC_SETTIMEOUT: 266 + ret = get_user(time, p); 267 + if (ret) 268 + break; 269 + ret = at32_wdt_settimeout(time); 270 + if (ret) 271 + break; 272 + /* Enable new time value */ 273 + at32_wdt_start(); 274 + /* fall through */ 275 + case WDIOC_GETTIMEOUT: 276 + ret = put_user(wdt->timeout, p); 243 277 break; 244 278 } 245 279
+14 -14
drivers/watchdog/at91rm9200_wdt.c
··· 137 137 int new_value; 138 138 139 139 switch (cmd) { 140 - case WDIOC_KEEPALIVE: 141 - at91_wdt_reload(); /* pat the watchdog */ 142 - return 0; 143 140 case WDIOC_GETSUPPORT: 144 141 return copy_to_user(argp, &at91_wdt_info, 145 142 sizeof(at91_wdt_info)) ? -EFAULT : 0; 146 - case WDIOC_SETTIMEOUT: 147 - if (get_user(new_value, p)) 148 - return -EFAULT; 149 - if (at91_wdt_settimeout(new_value)) 150 - return -EINVAL; 151 - /* Enable new time value */ 152 - at91_wdt_start(); 153 - /* Return current value */ 154 - return put_user(wdt_time, p); 155 - case WDIOC_GETTIMEOUT: 156 - return put_user(wdt_time, p); 157 143 case WDIOC_GETSTATUS: 158 144 case WDIOC_GETBOOTSTATUS: 159 145 return put_user(0, p); ··· 151 165 if (new_value & WDIOS_ENABLECARD) 152 166 at91_wdt_start(); 153 167 return 0; 168 + case WDIOC_KEEPALIVE: 169 + at91_wdt_reload(); /* pat the watchdog */ 170 + return 0; 171 + case WDIOC_SETTIMEOUT: 172 + if (get_user(new_value, p)) 173 + return -EFAULT; 174 + if (at91_wdt_settimeout(new_value)) 175 + return -EINVAL; 176 + /* Enable new time value */ 177 + at91_wdt_start(); 178 + /* Return current value */ 179 + return put_user(wdt_time, p); 180 + case WDIOC_GETTIMEOUT: 181 + return put_user(wdt_time, p); 154 182 default: 155 183 return -ENOTTY; 156 184 }
+14 -14
drivers/watchdog/bfin_wdt.c
··· 265 265 case WDIOC_GETSTATUS: 266 266 case WDIOC_GETBOOTSTATUS: 267 267 return put_user(!!(_bfin_swrst & SWRST_RESET_WDOG), p); 268 - case WDIOC_KEEPALIVE: 269 - bfin_wdt_keepalive(); 270 - return 0; 271 - case WDIOC_SETTIMEOUT: { 272 - int new_timeout; 273 - 274 - if (get_user(new_timeout, p)) 275 - return -EFAULT; 276 - if (bfin_wdt_set_timeout(new_timeout)) 277 - return -EINVAL; 278 - } 279 - /* Fall */ 280 - case WDIOC_GETTIMEOUT: 281 - return put_user(timeout, p); 282 268 case WDIOC_SETOPTIONS: { 283 269 unsigned long flags; 284 270 int options, ret = -EINVAL; ··· 284 298 spin_unlock_irqrestore(&bfin_wdt_spinlock, flags); 285 299 return ret; 286 300 } 301 + case WDIOC_KEEPALIVE: 302 + bfin_wdt_keepalive(); 303 + return 0; 304 + case WDIOC_SETTIMEOUT: { 305 + int new_timeout; 306 + 307 + if (get_user(new_timeout, p)) 308 + return -EFAULT; 309 + if (bfin_wdt_set_timeout(new_timeout)) 310 + return -EINVAL; 311 + } 312 + /* Fall */ 313 + case WDIOC_GETTIMEOUT: 314 + return put_user(timeout, p); 287 315 default: 288 316 return -ENOTTY; 289 317 }
+9 -9
drivers/watchdog/booke_wdt.c
··· 99 99 tmp = mfspr(SPRN_TSR) & TSR_WRS(3); 100 100 /* returns 1 if last reset was caused by the WDT */ 101 101 return (tmp ? 1 : 0); 102 + case WDIOC_SETOPTIONS: 103 + if (get_user(tmp, p)) 104 + return -EINVAL; 105 + if (tmp == WDIOS_ENABLECARD) { 106 + booke_wdt_ping(); 107 + break; 108 + } else 109 + return -EINVAL; 110 + return 0; 102 111 case WDIOC_KEEPALIVE: 103 112 booke_wdt_ping(); 104 113 return 0; ··· 119 110 return 0; 120 111 case WDIOC_GETTIMEOUT: 121 112 return put_user(booke_wdt_period, p); 122 - case WDIOC_SETOPTIONS: 123 - if (get_user(tmp, p)) 124 - return -EINVAL; 125 - if (tmp == WDIOS_ENABLECARD) { 126 - booke_wdt_ping(); 127 - break; 128 - } else 129 - return -EINVAL; 130 - return 0; 131 113 default: 132 114 return -ENOTTY; 133 115 }
+6 -6
drivers/watchdog/cpu5wdt.c
··· 160 160 }; 161 161 162 162 switch (cmd) { 163 - case WDIOC_KEEPALIVE: 164 - cpu5wdt_reset(); 163 + case WDIOC_GETSUPPORT: 164 + if (copy_to_user(argp, &ident, sizeof(ident))) 165 + return -EFAULT; 165 166 break; 166 167 case WDIOC_GETSTATUS: 167 168 value = inb(port + CPU5WDT_STATUS_REG); ··· 170 169 return put_user(value, p); 171 170 case WDIOC_GETBOOTSTATUS: 172 171 return put_user(0, p); 173 - case WDIOC_GETSUPPORT: 174 - if (copy_to_user(argp, &ident, sizeof(ident))) 175 - return -EFAULT; 176 - break; 177 172 case WDIOC_SETOPTIONS: 178 173 if (get_user(value, p)) 179 174 return -EFAULT; ··· 177 180 cpu5wdt_start(); 178 181 if (value & WDIOS_DISABLECARD) 179 182 cpu5wdt_stop(); 183 + break; 184 + case WDIOC_KEEPALIVE: 185 + cpu5wdt_reset(); 180 186 break; 181 187 default: 182 188 return -ENOTTY;
+4 -4
drivers/watchdog/davinci_wdt.c
··· 159 159 ret = put_user(0, (int *)arg); 160 160 break; 161 161 162 - case WDIOC_GETTIMEOUT: 163 - ret = put_user(heartbeat, (int *)arg); 164 - break; 165 - 166 162 case WDIOC_KEEPALIVE: 167 163 wdt_service(); 168 164 ret = 0; 165 + break; 166 + 167 + case WDIOC_GETTIMEOUT: 168 + ret = put_user(heartbeat, (int *)arg); 169 169 break; 170 170 } 171 171 return ret;
+5 -5
drivers/watchdog/ep93xx_wdt.c
··· 155 155 ret = put_user(boot_status, (int __user *)arg); 156 156 break; 157 157 158 - case WDIOC_GETTIMEOUT: 159 - /* actually, it is 0.250 seconds.... */ 160 - ret = put_user(1, (int __user *)arg); 161 - break; 162 - 163 158 case WDIOC_KEEPALIVE: 164 159 wdt_keepalive(); 165 160 ret = 0; 161 + break; 162 + 163 + case WDIOC_GETTIMEOUT: 164 + /* actually, it is 0.250 seconds.... */ 165 + ret = put_user(1, (int __user *)arg); 166 166 break; 167 167 } 168 168 return ret;
+18 -18
drivers/watchdog/eurotechwdt.c
··· 249 249 int options, retval = -EINVAL; 250 250 251 251 switch (cmd) { 252 - default: 253 - return -ENOTTY; 254 - 255 252 case WDIOC_GETSUPPORT: 256 253 return copy_to_user(argp, &ident, sizeof(ident)) ? -EFAULT : 0; 257 254 258 255 case WDIOC_GETSTATUS: 259 256 case WDIOC_GETBOOTSTATUS: 260 257 return put_user(0, p); 258 + 259 + case WDIOC_SETOPTIONS: 260 + if (get_user(options, p)) 261 + return -EFAULT; 262 + spin_lock(&eurwdt_lock); 263 + if (options & WDIOS_DISABLECARD) { 264 + eurwdt_disable_timer(); 265 + retval = 0; 266 + } 267 + if (options & WDIOS_ENABLECARD) { 268 + eurwdt_activate_timer(); 269 + eurwdt_ping(); 270 + retval = 0; 271 + } 272 + spin_unlock(&eurwdt_lock); 273 + return retval; 261 274 262 275 case WDIOC_KEEPALIVE: 263 276 spin_lock(&eurwdt_lock); ··· 295 282 case WDIOC_GETTIMEOUT: 296 283 return put_user(eurwdt_timeout, p); 297 284 298 - case WDIOC_SETOPTIONS: 299 - if (get_user(options, p)) 300 - return -EFAULT; 301 - spin_lock(&eurwdt_lock); 302 - if (options & WDIOS_DISABLECARD) { 303 - eurwdt_disable_timer(); 304 - retval = 0; 305 - } 306 - if (options & WDIOS_ENABLECARD) { 307 - eurwdt_activate_timer(); 308 - eurwdt_ping(); 309 - retval = 0; 310 - } 311 - spin_unlock(&eurwdt_lock); 312 - return retval; 285 + default: 286 + return -ENOTTY; 313 287 } 314 288 } 315 289
+14 -16
drivers/watchdog/geodewdt.c
··· 159 159 case WDIOC_GETBOOTSTATUS: 160 160 return put_user(0, p); 161 161 162 - case WDIOC_KEEPALIVE: 163 - geodewdt_ping(); 164 - return 0; 165 - 166 - case WDIOC_SETTIMEOUT: 167 - if (get_user(interval, p)) 168 - return -EFAULT; 169 - 170 - if (geodewdt_set_heartbeat(interval)) 171 - return -EINVAL; 172 - 173 - /* Fall through */ 174 - 175 - case WDIOC_GETTIMEOUT: 176 - return put_user(timeout, p); 177 - 178 162 case WDIOC_SETOPTIONS: 179 163 { 180 164 int options, ret = -EINVAL; ··· 178 194 179 195 return ret; 180 196 } 197 + case WDIOC_KEEPALIVE: 198 + geodewdt_ping(); 199 + return 0; 200 + 201 + case WDIOC_SETTIMEOUT: 202 + if (get_user(interval, p)) 203 + return -EFAULT; 204 + 205 + if (geodewdt_set_heartbeat(interval)) 206 + return -EINVAL; 207 + /* Fall through */ 208 + case WDIOC_GETTIMEOUT: 209 + return put_user(timeout, p); 210 + 181 211 default: 182 212 return -ENOTTY; 183 213 }
+4 -4
drivers/watchdog/i6300esb.c
··· 280 280 case WDIOC_GETBOOTSTATUS: 281 281 return put_user(triggered, p); 282 282 283 - case WDIOC_KEEPALIVE: 284 - esb_timer_keepalive(); 285 - return 0; 286 - 287 283 case WDIOC_SETOPTIONS: 288 284 { 289 285 if (get_user(new_options, p)) ··· 297 301 } 298 302 return retval; 299 303 } 304 + case WDIOC_KEEPALIVE: 305 + esb_timer_keepalive(); 306 + return 0; 307 + 300 308 case WDIOC_SETTIMEOUT: 301 309 { 302 310 if (get_user(new_heartbeat, p))
+4 -4
drivers/watchdog/iTCO_wdt.c
··· 532 532 case WDIOC_GETBOOTSTATUS: 533 533 return put_user(0, p); 534 534 535 - case WDIOC_KEEPALIVE: 536 - iTCO_wdt_keepalive(); 537 - return 0; 538 - 539 535 case WDIOC_SETOPTIONS: 540 536 { 541 537 if (get_user(new_options, p)) ··· 548 552 } 549 553 return retval; 550 554 } 555 + case WDIOC_KEEPALIVE: 556 + iTCO_wdt_keepalive(); 557 + return 0; 558 + 551 559 case WDIOC_SETTIMEOUT: 552 560 { 553 561 if (get_user(new_heartbeat, p))
+15 -15
drivers/watchdog/ib700wdt.c
··· 213 213 case WDIOC_GETBOOTSTATUS: 214 214 return put_user(0, p); 215 215 216 - case WDIOC_KEEPALIVE: 217 - ibwdt_ping(); 218 - break; 219 - 220 - case WDIOC_SETTIMEOUT: 221 - if (get_user(new_margin, p)) 222 - return -EFAULT; 223 - if (ibwdt_set_heartbeat(new_margin)) 224 - return -EINVAL; 225 - ibwdt_ping(); 226 - /* Fall */ 227 - 228 - case WDIOC_GETTIMEOUT: 229 - return put_user(wd_times[wd_margin], p); 230 - 231 216 case WDIOC_SETOPTIONS: 232 217 { 233 218 int options, retval = -EINVAL; ··· 230 245 } 231 246 return retval; 232 247 } 248 + case WDIOC_KEEPALIVE: 249 + ibwdt_ping(); 250 + break; 251 + 252 + case WDIOC_SETTIMEOUT: 253 + if (get_user(new_margin, p)) 254 + return -EFAULT; 255 + if (ibwdt_set_heartbeat(new_margin)) 256 + return -EINVAL; 257 + ibwdt_ping(); 258 + /* Fall */ 259 + 260 + case WDIOC_GETTIMEOUT: 261 + return put_user(wd_times[wd_margin], p); 262 + 233 263 default: 234 264 return -ENOTTY; 235 265 }
+10 -10
drivers/watchdog/ibmasr.c
··· 287 287 case WDIOC_GETSTATUS: 288 288 case WDIOC_GETBOOTSTATUS: 289 289 return put_user(0, p); 290 - case WDIOC_KEEPALIVE: 291 - asr_toggle(); 292 - return 0; 293 - /* 294 - * The hardware has a fixed timeout value, so no WDIOC_SETTIMEOUT 295 - * and WDIOC_GETTIMEOUT always returns 256. 296 - */ 297 - case WDIOC_GETTIMEOUT: 298 - heartbeat = 256; 299 - return put_user(heartbeat, p); 300 290 case WDIOC_SETOPTIONS: 301 291 { 302 292 int new_options, retval = -EINVAL; ··· 303 313 } 304 314 return retval; 305 315 } 316 + case WDIOC_KEEPALIVE: 317 + asr_toggle(); 318 + return 0; 319 + /* 320 + * The hardware has a fixed timeout value, so no WDIOC_SETTIMEOUT 321 + * and WDIOC_GETTIMEOUT always returns 256. 322 + */ 323 + case WDIOC_GETTIMEOUT: 324 + heartbeat = 256; 325 + return put_user(heartbeat, p); 306 326 default: 307 327 return -ENOTTY; 308 328 }
+5 -5
drivers/watchdog/indydog.c
··· 128 128 case WDIOC_GETSTATUS: 129 129 case WDIOC_GETBOOTSTATUS: 130 130 return put_user(0, (int *)arg); 131 - case WDIOC_KEEPALIVE: 132 - indydog_ping(); 133 - return 0; 134 - case WDIOC_GETTIMEOUT: 135 - return put_user(WATCHDOG_TIMEOUT, (int *)arg); 136 131 case WDIOC_SETOPTIONS: 137 132 { 138 133 if (get_user(options, (int *)arg)) ··· 142 147 } 143 148 return retval; 144 149 } 150 + case WDIOC_KEEPALIVE: 151 + indydog_ping(); 152 + return 0; 153 + case WDIOC_GETTIMEOUT: 154 + return put_user(WATCHDOG_TIMEOUT, (int *)arg); 145 155 default: 146 156 return -ENOTTY; 147 157 }
+9 -9
drivers/watchdog/iop_wdt.c
··· 153 153 ret = put_user(boot_status, argp); 154 154 break; 155 155 156 - case WDIOC_GETTIMEOUT: 157 - ret = put_user(iop_watchdog_timeout(), argp); 158 - break; 159 - 160 - case WDIOC_KEEPALIVE: 161 - wdt_enable(); 162 - ret = 0; 163 - break; 164 - 165 156 case WDIOC_SETOPTIONS: 166 157 if (get_user(options, (int *)arg)) 167 158 return -EFAULT; ··· 171 180 wdt_enable(); 172 181 ret = 0; 173 182 } 183 + break; 184 + 185 + case WDIOC_KEEPALIVE: 186 + wdt_enable(); 187 + ret = 0; 188 + break; 189 + 190 + case WDIOC_GETTIMEOUT: 191 + ret = put_user(iop_watchdog_timeout(), argp); 174 192 break; 175 193 } 176 194 return ret;
+2 -2
drivers/watchdog/it8712f_wdt.c
··· 244 244 int value; 245 245 246 246 switch (cmd) { 247 - default: 248 - return -ENOTTY; 249 247 case WDIOC_GETSUPPORT: 250 248 if (copy_to_user(argp, &ident, sizeof(ident))) 251 249 return -EFAULT; ··· 282 284 if (put_user(margin, p)) 283 285 return -EFAULT; 284 286 return 0; 287 + default: 288 + return -ENOTTY; 285 289 } 286 290 } 287 291
+5 -5
drivers/watchdog/ixp2000_wdt.c
··· 126 126 ret = put_user(0, (int *)arg); 127 127 break; 128 128 129 + case WDIOC_KEEPALIVE: 130 + wdt_enable(); 131 + ret = 0; 132 + break; 133 + 129 134 case WDIOC_SETTIMEOUT: 130 135 ret = get_user(time, (int *)arg); 131 136 if (ret) ··· 147 142 148 143 case WDIOC_GETTIMEOUT: 149 144 ret = put_user(heartbeat, (int *)arg); 150 - break; 151 - 152 - case WDIOC_KEEPALIVE: 153 - wdt_enable(); 154 - ret = 0; 155 145 break; 156 146 } 157 147
+5 -5
drivers/watchdog/ixp4xx_wdt.c
··· 117 117 ret = put_user(boot_status, (int *)arg); 118 118 break; 119 119 120 + case WDIOC_KEEPALIVE: 121 + wdt_enable(); 122 + ret = 0; 123 + break; 124 + 120 125 case WDIOC_SETTIMEOUT: 121 126 ret = get_user(time, (int *)arg); 122 127 if (ret) ··· 138 133 139 134 case WDIOC_GETTIMEOUT: 140 135 ret = put_user(heartbeat, (int *)arg); 141 - break; 142 - 143 - case WDIOC_KEEPALIVE: 144 - wdt_enable(); 145 - ret = 0; 146 136 break; 147 137 } 148 138 return ret;
+14 -14
drivers/watchdog/ks8695_wdt.c
··· 161 161 int new_value; 162 162 163 163 switch (cmd) { 164 - case WDIOC_KEEPALIVE: 165 - ks8695_wdt_reload(); /* pat the watchdog */ 166 - return 0; 167 164 case WDIOC_GETSUPPORT: 168 165 return copy_to_user(argp, &ks8695_wdt_info, 169 166 sizeof(ks8695_wdt_info)) ? -EFAULT : 0; 170 - case WDIOC_SETTIMEOUT: 171 - if (get_user(new_value, p)) 172 - return -EFAULT; 173 - if (ks8695_wdt_settimeout(new_value)) 174 - return -EINVAL; 175 - /* Enable new time value */ 176 - ks8695_wdt_start(); 177 - /* Return current value */ 178 - return put_user(wdt_time, p); 179 - case WDIOC_GETTIMEOUT: 180 - return put_user(wdt_time, p); 181 167 case WDIOC_GETSTATUS: 182 168 case WDIOC_GETBOOTSTATUS: 183 169 return put_user(0, p); ··· 175 189 if (new_value & WDIOS_ENABLECARD) 176 190 ks8695_wdt_start(); 177 191 return 0; 192 + case WDIOC_KEEPALIVE: 193 + ks8695_wdt_reload(); /* pat the watchdog */ 194 + return 0; 195 + case WDIOC_SETTIMEOUT: 196 + if (get_user(new_value, p)) 197 + return -EFAULT; 198 + if (ks8695_wdt_settimeout(new_value)) 199 + return -EINVAL; 200 + /* Enable new time value */ 201 + ks8695_wdt_start(); 202 + /* Return current value */ 203 + return put_user(wdt_time, p); 204 + case WDIOC_GETTIMEOUT: 205 + return put_user(wdt_time, p); 178 206 default: 179 207 return -ENOTTY; 180 208 }
+4 -4
drivers/watchdog/mixcomwd.c
··· 208 208 }; 209 209 210 210 switch (cmd) { 211 + case WDIOC_GETSUPPORT: 212 + if (copy_to_user(argp, &ident, sizeof(ident))) 213 + return -EFAULT; 214 + break; 211 215 case WDIOC_GETSTATUS: 212 216 status = mixcomwd_opened; 213 217 if (!nowayout) ··· 219 215 return put_user(status, p); 220 216 case WDIOC_GETBOOTSTATUS: 221 217 return put_user(0, p); 222 - case WDIOC_GETSUPPORT: 223 - if (copy_to_user(argp, &ident, sizeof(ident))) 224 - return -EFAULT; 225 - break; 226 218 case WDIOC_KEEPALIVE: 227 219 mixcomwd_ping(); 228 220 break;
+6 -6
drivers/watchdog/mpcore_wdt.c
··· 243 243 ret = 0; 244 244 break; 245 245 246 + case WDIOC_GETSTATUS: 247 + case WDIOC_GETBOOTSTATUS: 248 + uarg.i = 0; 249 + ret = 0; 250 + break; 251 + 246 252 case WDIOC_SETOPTIONS: 247 253 ret = -EINVAL; 248 254 if (uarg.i & WDIOS_DISABLECARD) { ··· 259 253 mpcore_wdt_start(wdt); 260 254 ret = 0; 261 255 } 262 - break; 263 - 264 - case WDIOC_GETSTATUS: 265 - case WDIOC_GETBOOTSTATUS: 266 - uarg.i = 0; 267 - ret = 0; 268 256 break; 269 257 270 258 case WDIOC_KEEPALIVE:
+6 -6
drivers/watchdog/mtx-1_wdt.c
··· 148 148 }; 149 149 150 150 switch (cmd) { 151 - case WDIOC_KEEPALIVE: 152 - mtx1_wdt_reset(); 151 + case WDIOC_GETSUPPORT: 152 + if (copy_to_user(argp, &ident, sizeof(ident))) 153 + return -EFAULT; 153 154 break; 154 155 case WDIOC_GETSTATUS: 155 156 case WDIOC_GETBOOTSTATUS: 156 157 put_user(0, p); 157 - break; 158 - case WDIOC_GETSUPPORT: 159 - if (copy_to_user(argp, &ident, sizeof(ident))) 160 - return -EFAULT; 161 158 break; 162 159 case WDIOC_SETOPTIONS: 163 160 if (get_user(value, p)) ··· 166 169 else 167 170 return -EINVAL; 168 171 return 0; 172 + case WDIOC_KEEPALIVE: 173 + mtx1_wdt_reset(); 174 + break; 169 175 default: 170 176 return -ENOTTY; 171 177 }
+2 -2
drivers/watchdog/omap_wdt.c
··· 197 197 }; 198 198 199 199 switch (cmd) { 200 - default: 201 - return -ENOTTY; 202 200 case WDIOC_GETSUPPORT: 203 201 return copy_to_user((struct watchdog_info __user *)arg, &ident, 204 202 sizeof(ident)); ··· 229 231 /* Fall */ 230 232 case WDIOC_GETTIMEOUT: 231 233 return put_user(timer_margin, (int __user *)arg); 234 + default: 235 + return -ENOTTY; 232 236 } 233 237 } 234 238
+15 -15
drivers/watchdog/pc87413_wdt.c
··· 426 426 return put_user(pc87413_status(), uarg.i); 427 427 case WDIOC_GETBOOTSTATUS: 428 428 return put_user(0, uarg.i); 429 + case WDIOC_SETOPTIONS: 430 + { 431 + int options, retval = -EINVAL; 432 + if (get_user(options, uarg.i)) 433 + return -EFAULT; 434 + if (options & WDIOS_DISABLECARD) { 435 + pc87413_disable(); 436 + retval = 0; 437 + } 438 + if (options & WDIOS_ENABLECARD) { 439 + pc87413_enable(); 440 + retval = 0; 441 + } 442 + return retval; 443 + } 429 444 case WDIOC_KEEPALIVE: 430 445 pc87413_refresh(); 431 446 #ifdef DEBUG ··· 460 445 case WDIOC_GETTIMEOUT: 461 446 new_timeout = timeout * 60; 462 447 return put_user(new_timeout, uarg.i); 463 - case WDIOC_SETOPTIONS: 464 - { 465 - int options, retval = -EINVAL; 466 - if (get_user(options, uarg.i)) 467 - return -EFAULT; 468 - if (options & WDIOS_DISABLECARD) { 469 - pc87413_disable(); 470 - retval = 0; 471 - } 472 - if (options & WDIOS_ENABLECARD) { 473 - pc87413_enable(); 474 - retval = 0; 475 - } 476 - return retval; 477 - } 478 448 default: 479 449 return -ENOTTY; 480 450 }
+3 -3
drivers/watchdog/pcwd.c
··· 612 612 }; 613 613 614 614 switch (cmd) { 615 - default: 616 - return -ENOTTY; 617 - 618 615 case WDIOC_GETSUPPORT: 619 616 if (copy_to_user(argp, &ident, sizeof(ident))) 620 617 return -EFAULT; ··· 666 669 667 670 case WDIOC_GETTIMEOUT: 668 671 return put_user(heartbeat, argp); 672 + 673 + default: 674 + return -ENOTTY; 669 675 } 670 676 671 677 return 0;
+4 -4
drivers/watchdog/pcwd_pci.c
··· 494 494 return put_user(temperature, p); 495 495 } 496 496 497 - case WDIOC_KEEPALIVE: 498 - pcipcwd_keepalive(); 499 - return 0; 500 - 501 497 case WDIOC_SETOPTIONS: 502 498 { 503 499 int new_options, retval = -EINVAL; ··· 520 524 521 525 return retval; 522 526 } 527 + 528 + case WDIOC_KEEPALIVE: 529 + pcipcwd_keepalive(); 530 + return 0; 523 531 524 532 case WDIOC_SETTIMEOUT: 525 533 {
+4 -4
drivers/watchdog/pcwd_usb.c
··· 400 400 return put_user(temperature, p); 401 401 } 402 402 403 - case WDIOC_KEEPALIVE: 404 - usb_pcwd_keepalive(usb_pcwd_device); 405 - return 0; 406 - 407 403 case WDIOC_SETOPTIONS: 408 404 { 409 405 int new_options, retval = -EINVAL; ··· 419 423 420 424 return retval; 421 425 } 426 + 427 + case WDIOC_KEEPALIVE: 428 + usb_pcwd_keepalive(usb_pcwd_device); 429 + return 0; 422 430 423 431 case WDIOC_SETTIMEOUT: 424 432 {
+5 -5
drivers/watchdog/pnx4008_wdt.c
··· 194 194 ret = put_user(boot_status, (int *)arg); 195 195 break; 196 196 197 + case WDIOC_KEEPALIVE: 198 + wdt_enable(); 199 + ret = 0; 200 + break; 201 + 197 202 case WDIOC_SETTIMEOUT: 198 203 ret = get_user(time, (int *)arg); 199 204 if (ret) ··· 215 210 216 211 case WDIOC_GETTIMEOUT: 217 212 ret = put_user(heartbeat, (int *)arg); 218 - break; 219 - 220 - case WDIOC_KEEPALIVE: 221 - wdt_enable(); 222 - ret = 0; 223 213 break; 224 214 } 225 215 return ret;
+2 -2
drivers/watchdog/s3c2410_wdt.c
··· 305 305 int new_margin; 306 306 307 307 switch (cmd) { 308 - default: 309 - return -ENOTTY; 310 308 case WDIOC_GETSUPPORT: 311 309 return copy_to_user(argp, &s3c2410_wdt_ident, 312 310 sizeof(s3c2410_wdt_ident)) ? -EFAULT : 0; ··· 323 325 return put_user(tmr_margin, p); 324 326 case WDIOC_GETTIMEOUT: 325 327 return put_user(tmr_margin, p); 328 + default: 329 + return -ENOTTY; 326 330 } 327 331 } 328 332
+5 -5
drivers/watchdog/sa1100_wdt.c
··· 107 107 ret = put_user(boot_status, p); 108 108 break; 109 109 110 + case WDIOC_KEEPALIVE: 111 + OSMR3 = OSCR + pre_margin; 112 + ret = 0; 113 + break; 114 + 110 115 case WDIOC_SETTIMEOUT: 111 116 ret = get_user(time, p); 112 117 if (ret) ··· 128 123 129 124 case WDIOC_GETTIMEOUT: 130 125 ret = put_user(pre_margin / OSCR_FREQ, p); 131 - break; 132 - 133 - case WDIOC_KEEPALIVE: 134 - OSMR3 = OSCR + pre_margin; 135 - ret = 0; 136 126 break; 137 127 } 138 128 return ret;
+5 -5
drivers/watchdog/sb_wdog.c
··· 182 182 ret = put_user(0, p); 183 183 break; 184 184 185 + case WDIOC_KEEPALIVE: 186 + sbwdog_pet(user_dog); 187 + ret = 0; 188 + break; 189 + 185 190 case WDIOC_SETTIMEOUT: 186 191 ret = get_user(time, p); 187 192 if (ret) ··· 207 202 * which is 1*8 before the config register 208 203 */ 209 204 ret = put_user(__raw_readq(user_dog - 8) / 1000000, p); 210 - break; 211 - 212 - case WDIOC_KEEPALIVE: 213 - sbwdog_pet(user_dog); 214 - ret = 0; 215 205 break; 216 206 } 217 207 return ret;
+5 -5
drivers/watchdog/sbc60xxwdt.c
··· 237 237 }; 238 238 239 239 switch (cmd) { 240 - default: 241 - return -ENOTTY; 242 240 case WDIOC_GETSUPPORT: 243 241 return copy_to_user(argp, &ident, sizeof(ident))? -EFAULT : 0; 244 242 case WDIOC_GETSTATUS: 245 243 case WDIOC_GETBOOTSTATUS: 246 244 return put_user(0, p); 247 - case WDIOC_KEEPALIVE: 248 - wdt_keepalive(); 249 - return 0; 250 245 case WDIOC_SETOPTIONS: 251 246 { 252 247 int new_options, retval = -EINVAL; ··· 257 262 } 258 263 return retval; 259 264 } 265 + case WDIOC_KEEPALIVE: 266 + wdt_keepalive(); 267 + return 0; 260 268 case WDIOC_SETTIMEOUT: 261 269 { 262 270 int new_timeout; ··· 275 277 } 276 278 case WDIOC_GETTIMEOUT: 277 279 return put_user(timeout, p); 280 + default: 281 + return -ENOTTY; 278 282 } 279 283 } 280 284
+29 -27
drivers/watchdog/sbc7240_wdt.c
··· 177 177 case WDIOC_GETSTATUS: 178 178 case WDIOC_GETBOOTSTATUS: 179 179 return put_user(0, (int __user *)arg); 180 + case WDIOC_SETOPTIONS: 181 + { 182 + int options; 183 + int retval = -EINVAL; 184 + 185 + if (get_user(options, (int __user *)arg)) 186 + return -EFAULT; 187 + 188 + if (options & WDIOS_DISABLECARD) { 189 + wdt_disable(); 190 + retval = 0; 191 + } 192 + 193 + if (options & WDIOS_ENABLECARD) { 194 + wdt_enable(); 195 + retval = 0; 196 + } 197 + 198 + return retval; 199 + } 180 200 case WDIOC_KEEPALIVE: 181 201 wdt_keepalive(); 182 202 return 0; 183 - case WDIOC_SETOPTIONS:{ 184 - int options; 185 - int retval = -EINVAL; 203 + case WDIOC_SETTIMEOUT: 204 + { 205 + int new_timeout; 186 206 187 - if (get_user(options, (int __user *)arg)) 188 - return -EFAULT; 207 + if (get_user(new_timeout, (int __user *)arg)) 208 + return -EFAULT; 189 209 190 - if (options & WDIOS_DISABLECARD) { 191 - wdt_disable(); 192 - retval = 0; 193 - } 210 + if (wdt_set_timeout(new_timeout)) 211 + return -EINVAL; 194 212 195 - if (options & WDIOS_ENABLECARD) { 196 - wdt_enable(); 197 - retval = 0; 198 - } 199 - 200 - return retval; 201 - } 202 - case WDIOC_SETTIMEOUT:{ 203 - int new_timeout; 204 - 205 - if (get_user(new_timeout, (int __user *)arg)) 206 - return -EFAULT; 207 - 208 - if (wdt_set_timeout(new_timeout)) 209 - return -EINVAL; 210 - 211 - /* Fall through */ 212 - } 213 + /* Fall through */ 214 + } 213 215 case WDIOC_GETTIMEOUT: 214 216 return put_user(timeout, (int __user *)arg); 215 217 default:
+5 -5
drivers/watchdog/sbc_epx_c3.c
··· 120 120 case WDIOC_GETSTATUS: 121 121 case WDIOC_GETBOOTSTATUS: 122 122 return put_user(0, argp); 123 - case WDIOC_KEEPALIVE: 124 - epx_c3_pet(); 125 - return 0; 126 - case WDIOC_GETTIMEOUT: 127 - return put_user(WATCHDOG_TIMEOUT, argp); 128 123 case WDIOC_SETOPTIONS: 129 124 if (get_user(options, argp)) 130 125 return -EFAULT; ··· 135 140 } 136 141 137 142 return retval; 143 + case WDIOC_KEEPALIVE: 144 + epx_c3_pet(); 145 + return 0; 146 + case WDIOC_GETTIMEOUT: 147 + return put_user(WATCHDOG_TIMEOUT, argp); 138 148 default: 139 149 return -ENOTTY; 140 150 }
+18 -18
drivers/watchdog/sc1200wdt.c
··· 207 207 case WDIOC_GETBOOTSTATUS: 208 208 return put_user(0, p); 209 209 210 - case WDIOC_KEEPALIVE: 211 - sc1200wdt_write_data(WDTO, timeout); 212 - return 0; 213 - 214 - case WDIOC_SETTIMEOUT: 215 - if (get_user(new_timeout, p)) 216 - return -EFAULT; 217 - /* the API states this is given in secs */ 218 - new_timeout /= 60; 219 - if (new_timeout < 0 || new_timeout > MAX_TIMEOUT) 220 - return -EINVAL; 221 - timeout = new_timeout; 222 - sc1200wdt_write_data(WDTO, timeout); 223 - /* fall through and return the new timeout */ 224 - 225 - case WDIOC_GETTIMEOUT: 226 - return put_user(timeout * 60, p); 227 - 228 210 case WDIOC_SETOPTIONS: 229 211 { 230 212 int options, retval = -EINVAL; ··· 226 244 227 245 return retval; 228 246 } 247 + case WDIOC_KEEPALIVE: 248 + sc1200wdt_write_data(WDTO, timeout); 249 + return 0; 250 + 251 + case WDIOC_SETTIMEOUT: 252 + if (get_user(new_timeout, p)) 253 + return -EFAULT; 254 + /* the API states this is given in secs */ 255 + new_timeout /= 60; 256 + if (new_timeout < 0 || new_timeout > MAX_TIMEOUT) 257 + return -EINVAL; 258 + timeout = new_timeout; 259 + sc1200wdt_write_data(WDTO, timeout); 260 + /* fall through and return the new timeout */ 261 + 262 + case WDIOC_GETTIMEOUT: 263 + return put_user(timeout * 60, p); 264 + 229 265 default: 230 266 return -ENOTTY; 231 267 }
+5 -5
drivers/watchdog/sc520_wdt.c
··· 291 291 }; 292 292 293 293 switch (cmd) { 294 - default: 295 - return -ENOTTY; 296 294 case WDIOC_GETSUPPORT: 297 295 return copy_to_user(argp, &ident, sizeof(ident)) ? -EFAULT : 0; 298 296 case WDIOC_GETSTATUS: 299 297 case WDIOC_GETBOOTSTATUS: 300 298 return put_user(0, p); 301 - case WDIOC_KEEPALIVE: 302 - wdt_keepalive(); 303 - return 0; 304 299 case WDIOC_SETOPTIONS: 305 300 { 306 301 int new_options, retval = -EINVAL; ··· 315 320 316 321 return retval; 317 322 } 323 + case WDIOC_KEEPALIVE: 324 + wdt_keepalive(); 325 + return 0; 318 326 case WDIOC_SETTIMEOUT: 319 327 { 320 328 int new_timeout; ··· 333 335 } 334 336 case WDIOC_GETTIMEOUT: 335 337 return put_user(timeout, p); 338 + default: 339 + return -ENOTTY; 336 340 } 337 341 } 338 342
+2 -2
drivers/watchdog/scx200_wdt.c
··· 168 168 int new_margin; 169 169 170 170 switch (cmd) { 171 - default: 172 - return -ENOTTY; 173 171 case WDIOC_GETSUPPORT: 174 172 if (copy_to_user(argp, &ident, sizeof(ident))) 175 173 return -EFAULT; ··· 192 194 if (put_user(margin, p)) 193 195 return -EFAULT; 194 196 return 0; 197 + default: 198 + return -ENOTTY; 195 199 } 196 200 } 197 201
+14 -14
drivers/watchdog/shwdt.c
··· 351 351 case WDIOC_GETSTATUS: 352 352 case WDIOC_GETBOOTSTATUS: 353 353 return put_user(0, (int *)arg); 354 - case WDIOC_KEEPALIVE: 355 - sh_wdt_keepalive(); 356 - return 0; 357 - case WDIOC_SETTIMEOUT: 358 - if (get_user(new_heartbeat, (int *)arg)) 359 - return -EFAULT; 360 - 361 - if (sh_wdt_set_heartbeat(new_heartbeat)) 362 - return -EINVAL; 363 - 364 - sh_wdt_keepalive(); 365 - /* Fall */ 366 - case WDIOC_GETTIMEOUT: 367 - return put_user(heartbeat, (int *)arg); 368 354 case WDIOC_SETOPTIONS: 369 355 if (get_user(options, (int *)arg)) 370 356 return -EFAULT; ··· 366 380 } 367 381 368 382 return retval; 383 + case WDIOC_KEEPALIVE: 384 + sh_wdt_keepalive(); 385 + return 0; 386 + case WDIOC_SETTIMEOUT: 387 + if (get_user(new_heartbeat, (int *)arg)) 388 + return -EFAULT; 389 + 390 + if (sh_wdt_set_heartbeat(new_heartbeat)) 391 + return -EINVAL; 392 + 393 + sh_wdt_keepalive(); 394 + /* Fall */ 395 + case WDIOC_GETTIMEOUT: 396 + return put_user(heartbeat, (int *)arg); 369 397 default: 370 398 return -ENOTTY; 371 399 }
+17 -17
drivers/watchdog/smsc37b787_wdt.c
··· 451 451 return put_user(wb_smsc_wdt_status(), uarg.i); 452 452 case WDIOC_GETBOOTSTATUS: 453 453 return put_user(0, uarg.i); 454 + case WDIOC_SETOPTIONS: 455 + { 456 + int options, retval = -EINVAL; 457 + 458 + if (get_user(options, uarg.i)) 459 + return -EFAULT; 460 + 461 + if (options & WDIOS_DISABLECARD) { 462 + wb_smsc_wdt_disable(); 463 + retval = 0; 464 + } 465 + if (options & WDIOS_ENABLECARD) { 466 + wb_smsc_wdt_enable(); 467 + retval = 0; 468 + } 469 + return retval; 470 + } 454 471 case WDIOC_KEEPALIVE: 455 472 wb_smsc_wdt_reset_timer(); 456 473 return 0; ··· 487 470 if (unit == UNIT_MINUTE) 488 471 new_timeout *= 60; 489 472 return put_user(new_timeout, uarg.i); 490 - case WDIOC_SETOPTIONS: 491 - { 492 - int options, retval = -EINVAL; 493 - 494 - if (get_user(options, uarg.i)) 495 - return -EFAULT; 496 - 497 - if (options & WDIOS_DISABLECARD) { 498 - wb_smsc_wdt_disable(); 499 - retval = 0; 500 - } 501 - if (options & WDIOS_ENABLECARD) { 502 - wb_smsc_wdt_enable(); 503 - retval = 0; 504 - } 505 - return retval; 506 - } 507 473 default: 508 474 return -ENOTTY; 509 475 }
+2 -2
drivers/watchdog/softdog.c
··· 206 206 .identity = "Software Watchdog", 207 207 }; 208 208 switch (cmd) { 209 - default: 210 - return -ENOTTY; 211 209 case WDIOC_GETSUPPORT: 212 210 return copy_to_user(argp, &ident, sizeof(ident)) ? -EFAULT : 0; 213 211 case WDIOC_GETSTATUS: ··· 223 225 /* Fall */ 224 226 case WDIOC_GETTIMEOUT: 225 227 return put_user(soft_margin, p); 228 + default: 229 + return -ENOTTY; 226 230 } 227 231 } 228 232
+2 -2
drivers/watchdog/txx9wdt.c
··· 142 142 }; 143 143 144 144 switch (cmd) { 145 - default: 146 - return -ENOTTY; 147 145 case WDIOC_GETSUPPORT: 148 146 return copy_to_user(argp, &ident, sizeof(ident)) ? -EFAULT : 0; 149 147 case WDIOC_GETSTATUS: ··· 161 163 /* Fall */ 162 164 case WDIOC_GETTIMEOUT: 163 165 return put_user(timeout, p); 166 + default: 167 + return -ENOTTY; 164 168 } 165 169 } 166 170
+12 -12
drivers/watchdog/w83627hf_wdt.c
··· 211 211 case WDIOC_GETSTATUS: 212 212 case WDIOC_GETBOOTSTATUS: 213 213 return put_user(0, p); 214 - case WDIOC_KEEPALIVE: 215 - wdt_ping(); 216 - break; 217 - case WDIOC_SETTIMEOUT: 218 - if (get_user(new_timeout, p)) 219 - return -EFAULT; 220 - if (wdt_set_heartbeat(new_timeout)) 221 - return -EINVAL; 222 - wdt_ping(); 223 - /* Fall */ 224 - case WDIOC_GETTIMEOUT: 225 - return put_user(timeout, p); 226 214 case WDIOC_SETOPTIONS: 227 215 { 228 216 int options, retval = -EINVAL; ··· 227 239 } 228 240 return retval; 229 241 } 242 + case WDIOC_KEEPALIVE: 243 + wdt_ping(); 244 + break; 245 + case WDIOC_SETTIMEOUT: 246 + if (get_user(new_timeout, p)) 247 + return -EFAULT; 248 + if (wdt_set_heartbeat(new_timeout)) 249 + return -EINVAL; 250 + wdt_ping(); 251 + /* Fall */ 252 + case WDIOC_GETTIMEOUT: 253 + return put_user(timeout, p); 230 254 default: 231 255 return -ENOTTY; 232 256 }
+15 -15
drivers/watchdog/w83697hf_wdt.c
··· 251 251 case WDIOC_GETBOOTSTATUS: 252 252 return put_user(0, p); 253 253 254 - case WDIOC_KEEPALIVE: 255 - wdt_ping(); 256 - break; 257 - 258 - case WDIOC_SETTIMEOUT: 259 - if (get_user(new_timeout, p)) 260 - return -EFAULT; 261 - if (wdt_set_heartbeat(new_timeout)) 262 - return -EINVAL; 263 - wdt_ping(); 264 - /* Fall */ 265 - 266 - case WDIOC_GETTIMEOUT: 267 - return put_user(timeout, p); 268 - 269 254 case WDIOC_SETOPTIONS: 270 255 { 271 256 int options, retval = -EINVAL; ··· 270 285 271 286 return retval; 272 287 } 288 + 289 + case WDIOC_KEEPALIVE: 290 + wdt_ping(); 291 + break; 292 + 293 + case WDIOC_SETTIMEOUT: 294 + if (get_user(new_timeout, p)) 295 + return -EFAULT; 296 + if (wdt_set_heartbeat(new_timeout)) 297 + return -EINVAL; 298 + wdt_ping(); 299 + /* Fall */ 300 + 301 + case WDIOC_GETTIMEOUT: 302 + return put_user(timeout, p); 273 303 274 304 default: 275 305 return -ENOTTY;
+5 -5
drivers/watchdog/w83877f_wdt.c
··· 254 254 }; 255 255 256 256 switch (cmd) { 257 - default: 258 - return -ENOTTY; 259 257 case WDIOC_GETSUPPORT: 260 258 return copy_to_user(argp, &ident, sizeof(ident)) ? -EFAULT : 0; 261 259 case WDIOC_GETSTATUS: 262 260 case WDIOC_GETBOOTSTATUS: 263 261 return put_user(0, p); 264 - case WDIOC_KEEPALIVE: 265 - wdt_keepalive(); 266 - return 0; 267 262 case WDIOC_SETOPTIONS: 268 263 { 269 264 int new_options, retval = -EINVAL; ··· 278 283 279 284 return retval; 280 285 } 286 + case WDIOC_KEEPALIVE: 287 + wdt_keepalive(); 288 + return 0; 281 289 case WDIOC_SETTIMEOUT: 282 290 { 283 291 int new_timeout; ··· 298 300 } 299 301 case WDIOC_GETTIMEOUT: 300 302 return put_user(timeout, p); 303 + default: 304 + return -ENOTTY; 301 305 } 302 306 } 303 307
+7 -7
drivers/watchdog/w83977f_wdt.c
··· 390 390 uarg.i = (int __user *)arg; 391 391 392 392 switch (cmd) { 393 - default: 394 - return -ENOTTY; 395 - 396 393 case WDIOC_GETSUPPORT: 397 394 return copy_to_user(uarg.ident, &ident, 398 395 sizeof(ident)) ? -EFAULT : 0; ··· 400 403 401 404 case WDIOC_GETBOOTSTATUS: 402 405 return put_user(0, uarg.i); 403 - 404 - case WDIOC_KEEPALIVE: 405 - wdt_keepalive(); 406 - return 0; 407 406 408 407 case WDIOC_SETOPTIONS: 409 408 if (get_user(new_options, uarg.i)) ··· 417 424 418 425 return retval; 419 426 427 + case WDIOC_KEEPALIVE: 428 + wdt_keepalive(); 429 + return 0; 430 + 420 431 case WDIOC_SETTIMEOUT: 421 432 if (get_user(new_timeout, uarg.i)) 422 433 return -EFAULT; ··· 433 436 434 437 case WDIOC_GETTIMEOUT: 435 438 return put_user(timeout, uarg.i); 439 + 440 + default: 441 + return -ENOTTY; 436 442 437 443 } 438 444 }
+16 -16
drivers/watchdog/wafer5823wdt.c
··· 145 145 case WDIOC_GETBOOTSTATUS: 146 146 return put_user(0, p); 147 147 148 - case WDIOC_KEEPALIVE: 149 - wafwdt_ping(); 150 - break; 151 - 152 - case WDIOC_SETTIMEOUT: 153 - if (get_user(new_timeout, p)) 154 - return -EFAULT; 155 - if ((new_timeout < 1) || (new_timeout > 255)) 156 - return -EINVAL; 157 - timeout = new_timeout; 158 - wafwdt_stop(); 159 - wafwdt_start(); 160 - /* Fall */ 161 - case WDIOC_GETTIMEOUT: 162 - return put_user(timeout, p); 163 - 164 148 case WDIOC_SETOPTIONS: 165 149 { 166 150 int options, retval = -EINVAL; ··· 164 180 165 181 return retval; 166 182 } 183 + 184 + case WDIOC_KEEPALIVE: 185 + wafwdt_ping(); 186 + break; 187 + 188 + case WDIOC_SETTIMEOUT: 189 + if (get_user(new_timeout, p)) 190 + return -EFAULT; 191 + if ((new_timeout < 1) || (new_timeout > 255)) 192 + return -EINVAL; 193 + timeout = new_timeout; 194 + wafwdt_stop(); 195 + wafwdt_start(); 196 + /* Fall */ 197 + case WDIOC_GETTIMEOUT: 198 + return put_user(timeout, p); 167 199 168 200 default: 169 201 return -ENOTTY;
+2 -2
drivers/watchdog/wdt.c
··· 373 373 #endif /* CONFIG_WDT_501 */ 374 374 375 375 switch (cmd) { 376 - default: 377 - return -ENOTTY; 378 376 case WDIOC_GETSUPPORT: 379 377 return copy_to_user(argp, &ident, sizeof(ident)) ? -EFAULT : 0; 380 378 case WDIOC_GETSTATUS: ··· 392 394 /* Fall */ 393 395 case WDIOC_GETTIMEOUT: 394 396 return put_user(heartbeat, p); 397 + default: 398 + return -ENOTTY; 395 399 } 396 400 } 397 401
+7 -7
drivers/watchdog/wdt977.c
··· 365 365 uarg.i = (int __user *)arg; 366 366 367 367 switch (cmd) { 368 - default: 369 - return -ENOTTY; 370 - 371 368 case WDIOC_GETSUPPORT: 372 369 return copy_to_user(uarg.ident, &ident, 373 370 sizeof(ident)) ? -EFAULT : 0; ··· 375 378 376 379 case WDIOC_GETBOOTSTATUS: 377 380 return put_user(0, uarg.i); 378 - 379 - case WDIOC_KEEPALIVE: 380 - wdt977_keepalive(); 381 - return 0; 382 381 383 382 case WDIOC_SETOPTIONS: 384 383 if (get_user(new_options, uarg.i)) ··· 392 399 393 400 return retval; 394 401 402 + case WDIOC_KEEPALIVE: 403 + wdt977_keepalive(); 404 + return 0; 405 + 395 406 case WDIOC_SETTIMEOUT: 396 407 if (get_user(new_timeout, uarg.i)) 397 408 return -EFAULT; ··· 408 411 409 412 case WDIOC_GETTIMEOUT: 410 413 return put_user(timeout, uarg.i); 414 + 415 + default: 416 + return -ENOTTY; 411 417 412 418 } 413 419 }
+3 -3
drivers/watchdog/wdt_pci.c
··· 428 428 #endif /* CONFIG_WDT_501_PCI */ 429 429 430 430 switch (cmd) { 431 - default: 432 - return -ENOTTY; 433 431 case WDIOC_GETSUPPORT: 434 432 return copy_to_user(argp, &ident, sizeof(ident)) ? -EFAULT : 0; 435 433 case WDIOC_GETSTATUS: ··· 447 449 /* Fall */ 448 450 case WDIOC_GETTIMEOUT: 449 451 return put_user(heartbeat, p); 450 - } 452 + default: 453 + return -ENOTTY; 454 + } 451 455 } 452 456 453 457 /**