Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

mtd: Uninline mtd_write_oob and move it to mtdcore.c

There's no reason for having mtd_write_oob inlined in mtd.h header.
Move it to mtdcore.c where it belongs.

Signed-off-by: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com>
Signed-off-by: Jacek Anaszewski <j.anaszewski@samsung.com>

authored by

Ezequiel Garcia and committed by
Jacek Anaszewski
0c034fe3 916fe619

+13 -11
+12
drivers/mtd/mtdcore.c
··· 997 997 } 998 998 EXPORT_SYMBOL_GPL(mtd_read_oob); 999 999 1000 + int mtd_write_oob(struct mtd_info *mtd, loff_t to, 1001 + struct mtd_oob_ops *ops) 1002 + { 1003 + ops->retlen = ops->oobretlen = 0; 1004 + if (!mtd->_write_oob) 1005 + return -EOPNOTSUPP; 1006 + if (!(mtd->flags & MTD_WRITEABLE)) 1007 + return -EROFS; 1008 + return mtd->_write_oob(mtd, to, ops); 1009 + } 1010 + EXPORT_SYMBOL_GPL(mtd_write_oob); 1011 + 1000 1012 /* 1001 1013 * Method to access the protection register area, present in some flash 1002 1014 * devices. The user data is one time programmable but the factory data is read
+1 -11
include/linux/mtd/mtd.h
··· 283 283 const u_char *buf); 284 284 285 285 int mtd_read_oob(struct mtd_info *mtd, loff_t from, struct mtd_oob_ops *ops); 286 - 287 - static inline int mtd_write_oob(struct mtd_info *mtd, loff_t to, 288 - struct mtd_oob_ops *ops) 289 - { 290 - ops->retlen = ops->oobretlen = 0; 291 - if (!mtd->_write_oob) 292 - return -EOPNOTSUPP; 293 - if (!(mtd->flags & MTD_WRITEABLE)) 294 - return -EROFS; 295 - return mtd->_write_oob(mtd, to, ops); 296 - } 286 + int mtd_write_oob(struct mtd_info *mtd, loff_t to, struct mtd_oob_ops *ops); 297 287 298 288 int mtd_get_fact_prot_info(struct mtd_info *mtd, size_t len, size_t *retlen, 299 289 struct otp_info *buf);