Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

host: ehci-w90x900: fix error return code

Return a negative error code on failure.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@@
identifier ret; expression e1,e2;
@@
(
if (\(ret < 0\|ret != 0\))
{ ... return ret; }
|
ret = 0
)
... when != ret = e1
when != &ret
*if(...)
{
... when != ret = e2
when forall
return ret;
}
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

authored by

Julia Lawall and committed by
Greg Kroah-Hartman
0bfed505 646a3843

+3 -1
+3 -1
drivers/usb/host/ehci-w90x900.c
··· 75 75 __raw_writel(val, ehci->regs+PHY1_CTR); 76 76 77 77 irq = platform_get_irq(pdev, 0); 78 - if (irq < 0) 78 + if (irq < 0) { 79 + retval = irq; 79 80 goto err2; 81 + } 80 82 81 83 retval = usb_add_hcd(hcd, irq, IRQF_SHARED); 82 84 if (retval != 0)