Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

tty_port: drop last traces of low_latency

The main purpose of tty_port::low_latency was removed in commit
a9c3f68f3cd8 (tty: Fix low_latency BUG) back in 2014. It was left in
place for drivers as an optional tune knob. But only one driver has been
using it until the previous commit. So remove this misconcept
completely, given there are no users.

Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Link: https://lore.kernel.org/r/20210105120239.28031-11-jslaby@suse.cz
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

authored by

Jiri Slaby and committed by
Greg Kroah-Hartman
0bc1bd09 bb914668

+3 -28
-1
Documentation/networking/caif/caif.rst
··· 68 68 * tty_status: Prints the bit-mask tty status information 69 69 70 70 - 0x01 - tty->warned is on. 71 - - 0x02 - tty->low_latency is on. 72 71 - 0x04 - tty->packed is on. 73 72 - 0x08 - tty->flow_stopped is on. 74 73 - 0x10 - tty->hw_stopped is on.
+1 -2
drivers/net/caif/caif_serial.c
··· 89 89 ser->tty_status = 90 90 ser->tty->stopped << 5 | 91 91 ser->tty->flow_stopped << 3 | 92 - ser->tty->packet << 2 | 93 - ser->tty->port->low_latency << 1; 92 + ser->tty->packet << 2; 94 93 } 95 94 static inline void debugfs_init(struct ser_device *ser, struct tty_struct *tty) 96 95 {
-1
drivers/s390/char/con3215.c
··· 914 914 915 915 tty_port_tty_set(&raw->port, tty); 916 916 917 - raw->port.low_latency = 0; /* don't use bottom half for pushing chars */ 918 917 /* 919 918 * Start up 3215 device 920 919 */
-1
drivers/s390/char/sclp_tty.c
··· 65 65 { 66 66 tty_port_tty_set(&sclp_port, tty); 67 67 tty->driver_data = NULL; 68 - sclp_port.low_latency = 0; 69 68 return 0; 70 69 } 71 70
-1
drivers/s390/char/sclp_vt220.c
··· 560 560 { 561 561 if (tty->count == 1) { 562 562 tty_port_tty_set(&sclp_vt220_port, tty); 563 - sclp_vt220_port.low_latency = 0; 564 563 if (!tty->winsize.ws_row && !tty->winsize.ws_col) { 565 564 tty->winsize.ws_row = 24; 566 565 tty->winsize.ws_col = 80;
-2
drivers/s390/char/tty3270.c
··· 967 967 tty->driver_data = tp; 968 968 tty->winsize.ws_row = tp->view.rows - 2; 969 969 tty->winsize.ws_col = tp->view.cols; 970 - tp->port.low_latency = 0; 971 970 tp->inattr = TF_INPUT; 972 971 goto port_install; 973 972 } ··· 995 996 return rc; 996 997 } 997 998 998 - tp->port.low_latency = 0; 999 999 tty->winsize.ws_row = tp->view.rows - 2; 1000 1000 tty->winsize.ws_col = tp->view.cols; 1001 1001
-3
drivers/tty/amiserial.c
··· 998 998 state->custom_divisor = ss->custom_divisor; 999 999 port->close_delay = ss->close_delay * HZ/100; 1000 1000 port->closing_wait = ss->closing_wait * HZ/100; 1001 - port->low_latency = (port->flags & ASYNC_LOW_LATENCY) ? 1 : 0; 1002 1001 1003 1002 check_and_exit: 1004 1003 if (tty_port_initialized(port)) { ··· 1384 1385 port->tty = tty; 1385 1386 tty->driver_data = info; 1386 1387 tty->port = port; 1387 - 1388 - port->low_latency = (port->flags & ASYNC_LOW_LATENCY) ? 1 : 0; 1389 1388 1390 1389 retval = startup(tty, info); 1391 1390 if (retval) {
+1 -1
drivers/tty/hvc/hvcs.c
··· 605 605 hvcsd->todo_mask |= HVCS_QUICK_READ; 606 606 607 607 spin_unlock_irqrestore(&hvcsd->lock, flags); 608 - /* This is synch because tty->low_latency == 1 */ 608 + /* This is synch -- FIXME :js: it is not! */ 609 609 if(got) 610 610 tty_flip_buffer_push(&hvcsd->port); 611 611
-1
drivers/tty/ipwireless/tty.c
··· 101 101 102 102 tty->port.tty = linux_tty; 103 103 linux_tty->driver_data = tty; 104 - tty->port.low_latency = 1; 105 104 106 105 if (tty->tty_type == TTYTYPE_MODEM) 107 106 ipwireless_ppp_open(tty->network);
-1
drivers/tty/mxser.c
··· 1273 1273 (ss->flags & ASYNC_FLAGS)); 1274 1274 port->close_delay = ss->close_delay * HZ / 100; 1275 1275 port->closing_wait = ss->closing_wait * HZ / 100; 1276 - port->low_latency = (port->flags & ASYNC_LOW_LATENCY) ? 1 : 0; 1277 1276 if ((port->flags & ASYNC_SPD_MASK) == ASYNC_SPD_CUST && 1278 1277 (ss->baud_base != info->baud_base || 1279 1278 ss->custom_divisor !=
-3
drivers/tty/serial/ifx6x60.c
··· 565 565 /* put port data into this tty */ 566 566 tty->driver_data = ifx_dev; 567 567 568 - /* allows flip string push from int context */ 569 - port->low_latency = 1; 570 - 571 568 /* set flag to allows data transfer */ 572 569 set_bit(IFX_SPI_STATE_IO_AVAILABLE, &ifx_dev->flags); 573 570
-3
drivers/tty/serial/max3100.c
··· 521 521 MAX3100_STATUS_PE | MAX3100_STATUS_FE | 522 522 MAX3100_STATUS_OE; 523 523 524 - /* we are sending char from a workqueue so enable */ 525 - s->port.state->port.low_latency = 1; 526 - 527 524 if (s->poll_time > 0) 528 525 del_timer_sync(&s->timer); 529 526
-3
drivers/tty/serial/serial_core.c
··· 975 975 port->closing_wait = closing_wait; 976 976 if (new_info->xmit_fifo_size) 977 977 uport->fifosize = new_info->xmit_fifo_size; 978 - port->low_latency = (uport->flags & UPF_LOW_LATENCY) ? 1 : 0; 979 978 980 979 check_and_exit: 981 980 retval = 0; ··· 1793 1794 uport = uart_port_check(state); 1794 1795 if (!uport || uport->flags & UPF_DEAD) 1795 1796 return -ENXIO; 1796 - 1797 - port->low_latency = (uport->flags & UPF_LOW_LATENCY) ? 1 : 0; 1798 1797 1799 1798 /* 1800 1799 * Start up the serial port.
+1 -2
include/linux/tty.h
··· 240 240 wait_queue_head_t delta_msr_wait; /* Modem status change */ 241 241 unsigned long flags; /* User TTY flags ASYNC_ */ 242 242 unsigned long iflags; /* Internal flags TTY_PORT_ */ 243 - unsigned char console:1, /* port is a console */ 244 - low_latency:1; /* optional: tune for latency */ 243 + unsigned char console:1; /* port is a console */ 245 244 struct mutex mutex; /* Locking */ 246 245 struct mutex buf_mutex; /* Buffer alloc lock */ 247 246 unsigned char *xmit_buf; /* Optional buffer */