Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

hexagon: fix livelock in uaccess

hexagon equivalent of 26178ec11ef3 "x86: mm: consolidate VM_FAULT_RETRY handling"
If e.g. get_user() triggers a page fault and a fatal signal is caught, we might
end up with handle_mm_fault() returning VM_FAULT_RETRY and not doing anything
to page tables. In such case we must *not* return to the faulting insn -
that would repeat the entire thing without making any progress; what we need
instead is to treat that as failed (user) memory access.

Acked-by: Brian Cain <bcain@quicinc.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>

Al Viro 0b92ed09 d835eb3a

+4 -1
+4 -1
arch/hexagon/mm/vm_fault.c
··· 93 93 94 94 fault = handle_mm_fault(vma, address, flags, regs); 95 95 96 - if (fault_signal_pending(fault, regs)) 96 + if (fault_signal_pending(fault, regs)) { 97 + if (!user_mode(regs)) 98 + goto no_context; 97 99 return; 100 + } 98 101 99 102 /* The fault is fully completed (including releasing mmap lock) */ 100 103 if (fault & VM_FAULT_COMPLETED)