Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

selftests/bpf: Migrate all deprecated perf_buffer uses

Migrate all old-style perf_buffer__new() and perf_buffer__new_raw()
calls to new v1.0+ variants.

Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Link: https://lore.kernel.org/bpf/20211111053624.190580-7-andrii@kernel.org

authored by

Andrii Nakryiko and committed by
Alexei Starovoitov
0b52a5f4 41788934

+11 -25
+2 -6
tools/testing/selftests/bpf/benchs/bench_ringbufs.c
··· 394 394 { 395 395 struct perfbuf_libbpf_ctx *ctx = &perfbuf_libbpf_ctx; 396 396 struct perf_event_attr attr; 397 - struct perf_buffer_raw_opts pb_opts = { 398 - .event_cb = perfbuf_process_sample_raw, 399 - .ctx = (void *)(long)0, 400 - .attr = &attr, 401 - }; 402 397 struct bpf_link *link; 403 398 404 399 ctx->skel = perfbuf_setup_skeleton(); ··· 418 423 } 419 424 420 425 ctx->perfbuf = perf_buffer__new_raw(bpf_map__fd(ctx->skel->maps.perfbuf), 421 - args.perfbuf_sz, &pb_opts); 426 + args.perfbuf_sz, &attr, 427 + perfbuf_process_sample_raw, NULL, NULL); 422 428 if (!ctx->perfbuf) { 423 429 fprintf(stderr, "failed to create perfbuf\n"); 424 430 exit(1);
+2 -3
tools/testing/selftests/bpf/prog_tests/get_stack_raw_tp.c
··· 85 85 const char *file_err = "./test_get_stack_rawtp_err.o"; 86 86 const char *prog_name = "raw_tracepoint/sys_enter"; 87 87 int i, err, prog_fd, exp_cnt = MAX_CNT_RAWTP; 88 - struct perf_buffer_opts pb_opts = {}; 89 88 struct perf_buffer *pb = NULL; 90 89 struct bpf_link *link = NULL; 91 90 struct timespec tv = {0, 10}; ··· 123 124 if (!ASSERT_OK_PTR(link, "attach_raw_tp")) 124 125 goto close_prog; 125 126 126 - pb_opts.sample_cb = get_stack_print_output; 127 - pb = perf_buffer__new(bpf_map__fd(map), 8, &pb_opts); 127 + pb = perf_buffer__new(bpf_map__fd(map), 8, get_stack_print_output, 128 + NULL, NULL, NULL); 128 129 if (!ASSERT_OK_PTR(pb, "perf_buf__new")) 129 130 goto close_prog; 130 131
+2 -4
tools/testing/selftests/bpf/prog_tests/kfree_skb.c
··· 66 66 struct bpf_map *perf_buf_map, *global_data; 67 67 struct bpf_program *prog, *fentry, *fexit; 68 68 struct bpf_object *obj, *obj2 = NULL; 69 - struct perf_buffer_opts pb_opts = {}; 70 69 struct perf_buffer *pb = NULL; 71 70 int err, kfree_skb_fd; 72 71 bool passed = false; ··· 111 112 goto close_prog; 112 113 113 114 /* set up perf buffer */ 114 - pb_opts.sample_cb = on_sample; 115 - pb_opts.ctx = &passed; 116 - pb = perf_buffer__new(bpf_map__fd(perf_buf_map), 1, &pb_opts); 115 + pb = perf_buffer__new(bpf_map__fd(perf_buf_map), 1, 116 + on_sample, NULL, &passed, NULL); 117 117 if (!ASSERT_OK_PTR(pb, "perf_buf__new")) 118 118 goto close_prog; 119 119
+2 -4
tools/testing/selftests/bpf/prog_tests/perf_buffer.c
··· 47 47 { 48 48 int err, on_len, nr_on_cpus = 0, nr_cpus, i, j; 49 49 int zero = 0, my_pid = getpid(); 50 - struct perf_buffer_opts pb_opts = {}; 51 50 struct test_perf_buffer *skel; 52 51 cpu_set_t cpu_seen; 53 52 struct perf_buffer *pb; ··· 81 82 goto out_close; 82 83 83 84 /* set up perf buffer */ 84 - pb_opts.sample_cb = on_sample; 85 - pb_opts.ctx = &cpu_seen; 86 - pb = perf_buffer__new(bpf_map__fd(skel->maps.perf_buf_map), 1, &pb_opts); 85 + pb = perf_buffer__new(bpf_map__fd(skel->maps.perf_buf_map), 1, 86 + on_sample, NULL, &cpu_seen, NULL); 87 87 if (!ASSERT_OK_PTR(pb, "perf_buf__new")) 88 88 goto out_close; 89 89
+2 -5
tools/testing/selftests/bpf/prog_tests/xdp_bpf2bpf.c
··· 49 49 struct vip key4 = {.protocol = 6, .family = AF_INET}; 50 50 struct bpf_program *prog; 51 51 struct perf_buffer *pb = NULL; 52 - struct perf_buffer_opts pb_opts = {}; 53 52 54 53 /* Load XDP program to introspect */ 55 54 pkt_skel = test_xdp__open_and_load(); ··· 85 86 goto out; 86 87 87 88 /* Set up perf buffer */ 88 - pb_opts.sample_cb = on_sample; 89 - pb_opts.ctx = &passed; 90 - pb = perf_buffer__new(bpf_map__fd(ftrace_skel->maps.perf_buf_map), 91 - 1, &pb_opts); 89 + pb = perf_buffer__new(bpf_map__fd(ftrace_skel->maps.perf_buf_map), 1, 90 + on_sample, NULL, &passed, NULL); 92 91 if (!ASSERT_OK_PTR(pb, "perf_buf__new")) 93 92 goto out; 94 93
+1 -3
tools/testing/selftests/bpf/test_tcpnotify_user.c
··· 72 72 { 73 73 const char *file = "test_tcpnotify_kern.o"; 74 74 struct bpf_map *perf_map, *global_map; 75 - struct perf_buffer_opts pb_opts = {}; 76 75 struct tcpnotify_globals g = {0}; 77 76 struct perf_buffer *pb = NULL; 78 77 const char *cg_path = "/foo"; ··· 116 117 return -1; 117 118 } 118 119 119 - pb_opts.sample_cb = dummyfn; 120 - pb = perf_buffer__new(bpf_map__fd(perf_map), 8, &pb_opts); 120 + pb = perf_buffer__new(bpf_map__fd(perf_map), 8, dummyfn, NULL, NULL, NULL); 121 121 if (!pb) 122 122 goto err; 123 123