Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

spidernet: revise link status logging

This patch revises the logging for link informations of spidernet.

- The link down message is too verbose because auto-negotiation timeout
occurs periodically while an ethernet cable is not connected.
- We want to see the link result, and we think it should be displayed.

Signed-off-by: Kou Ishizaki <kou.ishizaki@toshiba.co.jp>
Acked-by: Jens Osterkamp <jens@de.ibm.com>
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>

authored by

Ishizaki Kou and committed by
Jeff Garzik
0b50d753 9a11fcb5

+6 -4
+6 -4
drivers/net/spider_net.c
··· 2045 2045 /* if link didn't come up after SPIDER_NET_ANEG_TIMEOUT tries, setup phy again */ 2046 2046 if (card->aneg_count > SPIDER_NET_ANEG_TIMEOUT) { 2047 2047 2048 - pr_info("%s: link is down trying to bring it up\n", card->netdev->name); 2048 + pr_debug("%s: link is down trying to bring it up\n", 2049 + card->netdev->name); 2049 2050 2050 2051 switch (card->medium) { 2051 2052 case BCM54XX_COPPER: ··· 2097 2096 2098 2097 card->aneg_count = 0; 2099 2098 2100 - pr_debug("Found %s with %i Mbps, %s-duplex %sautoneg.\n", 2101 - phy->def->name, phy->speed, phy->duplex==1 ? "Full" : "Half", 2102 - phy->autoneg==1 ? "" : "no "); 2099 + pr_info("%s: link up, %i Mbps, %s-duplex %sautoneg.\n", 2100 + card->netdev->name, phy->speed, 2101 + phy->duplex == 1 ? "Full" : "Half", 2102 + phy->autoneg == 1 ? "" : "no "); 2103 2103 2104 2104 return; 2105 2105 }