Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

hydra: Fix regression caused during net_device_ops conversion

Changeset 5618f0d1193d6b051da9b59b0e32ad24397f06a4 ("hydra: convert to
net_device_ops") broke hydra by adding 8390.o to the link. That
meant that lib8390.c was included twice, once in hydra.c and once in
8390.c, subject to different macros. This patch reverts that by
avoiding the wrappers in 8390.c.

Fix based on commits 217cbfa856dc1cbc2890781626c4032d9e3ec59f ("mac8390:
fix regression caused during net_device_ops conversion") and
4e0168fa4842e27795a75b205a510f25b62181d9 ("mac8390: fix build with
NET_POLL_CONTROLLER").

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: stable@kernel.org
Signed-off-by: David S. Miller <davem@davemloft.net>

authored by

Geert Uytterhoeven and committed by
David S. Miller
0b25e015 cf7e032f

+8 -8
+1 -1
drivers/net/Makefile
··· 231 231 obj-$(CONFIG_DECLANCE) += declance.o 232 232 obj-$(CONFIG_ATARILANCE) += atarilance.o 233 233 obj-$(CONFIG_A2065) += a2065.o 234 - obj-$(CONFIG_HYDRA) += hydra.o 8390.o 234 + obj-$(CONFIG_HYDRA) += hydra.o 235 235 obj-$(CONFIG_ARIADNE) += ariadne.o 236 236 obj-$(CONFIG_CS89x0) += cs89x0.o 237 237 obj-$(CONFIG_MACSONIC) += macsonic.o
+7 -7
drivers/net/hydra.c
··· 98 98 .ndo_open = hydra_open, 99 99 .ndo_stop = hydra_close, 100 100 101 - .ndo_start_xmit = ei_start_xmit, 102 - .ndo_tx_timeout = ei_tx_timeout, 103 - .ndo_get_stats = ei_get_stats, 104 - .ndo_set_multicast_list = ei_set_multicast_list, 101 + .ndo_start_xmit = __ei_start_xmit, 102 + .ndo_tx_timeout = __ei_tx_timeout, 103 + .ndo_get_stats = __ei_get_stats, 104 + .ndo_set_multicast_list = __ei_set_multicast_list, 105 105 .ndo_validate_addr = eth_validate_addr, 106 - .ndo_set_mac_address = eth_mac_addr, 106 + .ndo_set_mac_address = eth_mac_addr, 107 107 .ndo_change_mtu = eth_change_mtu, 108 108 #ifdef CONFIG_NET_POLL_CONTROLLER 109 - .ndo_poll_controller = ei_poll, 109 + .ndo_poll_controller = __ei_poll, 110 110 #endif 111 111 }; 112 112 ··· 125 125 0x10, 0x12, 0x14, 0x16, 0x18, 0x1a, 0x1c, 0x1e, 126 126 }; 127 127 128 - dev = alloc_ei_netdev(); 128 + dev = ____alloc_ei_netdev(0); 129 129 if (!dev) 130 130 return -ENOMEM; 131 131