Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

media: mn88473: don't check retval after our own assignemt

No need to check a retval after we assigned a constant to it.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>

authored by

Wolfram Sang and committed by
Mauro Carvalho Chehab
0b25167d e6ec19a2

+2 -4
+2 -4
drivers/media/dvb-frontends/mn88473.c
··· 661 661 if (IS_ERR(dev->client[1])) { 662 662 ret = PTR_ERR(dev->client[1]); 663 663 dev_err(&client->dev, "I2C registration failed\n"); 664 - if (ret) 665 - goto err_regmap_0_regmap_exit; 664 + goto err_regmap_0_regmap_exit; 666 665 } 667 666 dev->regmap[1] = regmap_init_i2c(dev->client[1], &regmap_config); 668 667 if (IS_ERR(dev->regmap[1])) { ··· 674 675 if (IS_ERR(dev->client[2])) { 675 676 ret = PTR_ERR(dev->client[2]); 676 677 dev_err(&client->dev, "2nd I2C registration failed\n"); 677 - if (ret) 678 - goto err_regmap_1_regmap_exit; 678 + goto err_regmap_1_regmap_exit; 679 679 } 680 680 dev->regmap[2] = regmap_init_i2c(dev->client[2], &regmap_config); 681 681 if (IS_ERR(dev->regmap[2])) {