Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

uio_hv_generic: Fix another memory leak in error handling paths

Memory allocated by 'vmbus_alloc_ring()' at the beginning of the probe
function is never freed in the error handling path.

Add the missing 'vmbus_free_ring()' call.

Note that it is already freed in the .remove function.

Fixes: cdfa835c6e5e ("uio_hv_generic: defer opening vmbus until first use")
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Link: https://lore.kernel.org/r/0d86027b8eeed8e6360bc3d52bcdb328ff9bdca1.1620544055.git.christophe.jaillet@wanadoo.fr
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

authored by

Christophe JAILLET and committed by
Greg Kroah-Hartman
0b0226be 3ee098f9

+3 -1
+3 -1
drivers/uio/uio_hv_generic.c
··· 291 291 pdata->recv_buf = vzalloc(RECV_BUFFER_SIZE); 292 292 if (pdata->recv_buf == NULL) { 293 293 ret = -ENOMEM; 294 - goto fail_close; 294 + goto fail_free_ring; 295 295 } 296 296 297 297 ret = vmbus_establish_gpadl(channel, pdata->recv_buf, ··· 351 351 352 352 fail_close: 353 353 hv_uio_cleanup(dev, pdata); 354 + fail_free_ring: 355 + vmbus_free_ring(dev->channel); 354 356 355 357 return ret; 356 358 }