tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
fork atom

[SCSI] ibmvfc: Reduce unnecessary log noise

Reduces some unnecessary log noise by removing a printk during
host port state query and increasing the log level required to
log received async events.

Signed-off-by: Brian King <brking@linux.vnet.ibm.com>
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>

authored by

Brian King and committed by
James Bottomley 0ae808e0 e41443ec

+5 -2
unified split
+5 -2
drivers/scsi/ibmvscsi/ibmvfc.c
··· 963 case IBMVFC_HALTED: 964 fc_host_port_state(shost) = FC_PORTSTATE_BLOCKED; 965 break; 966 default: 967 ibmvfc_log(vhost, 3, "Unknown port state: %d\n", vhost->state); 968 fc_host_port_state(shost) = FC_PORTSTATE_UNKNOWN; ··· 1407 err = cmd_status[index].name; 1408 } 1409 1410 - if (!logerr && (vhost->log_level <= IBMVFC_DEFAULT_LOG_LEVEL)) 1411 return; 1412 1413 if (rsp->flags & FCP_RSP_LEN_VALID) ··· 2057 { 2058 const char *desc = ibmvfc_get_ae_desc(crq->event); 2059 2060 - ibmvfc_log(vhost, 2, "%s event received\n", desc); 2061 2062 switch (crq->event) { 2063 case IBMVFC_AE_LINK_UP:
··· 963 case IBMVFC_HALTED: 964 fc_host_port_state(shost) = FC_PORTSTATE_BLOCKED; 965 break; 966 + case IBMVFC_NO_CRQ: 967 + fc_host_port_state(shost) = FC_PORTSTATE_UNKNOWN; 968 + break; 969 default: 970 ibmvfc_log(vhost, 3, "Unknown port state: %d\n", vhost->state); 971 fc_host_port_state(shost) = FC_PORTSTATE_UNKNOWN; ··· 1404 err = cmd_status[index].name; 1405 } 1406 1407 + if (!logerr && (vhost->log_level <= (IBMVFC_DEFAULT_LOG_LEVEL + 1))) 1408 return; 1409 1410 if (rsp->flags & FCP_RSP_LEN_VALID) ··· 2054 { 2055 const char *desc = ibmvfc_get_ae_desc(crq->event); 2056 2057 + ibmvfc_log(vhost, 3, "%s event received\n", desc); 2058 2059 switch (crq->event) { 2060 case IBMVFC_AE_LINK_UP: