ARM: 8834/1: Fix: kprobes: optimized kprobes illegal instruction

commit e46daee53bb5 ("ARM: 8806/1: kprobes: Fix false positive with
FORTIFY_SOURCE") introduced a regression in optimized kprobes. It
triggers "invalid instruction" oopses when using kprobes instrumentation
through lttng and perf. This commit was introduced in kernel v4.20, and
has been backported to stable kernels 4.19 and 4.14.

This crash was also reported by Hongzhi Song on the redhat bugzilla
where the patch was originally introduced.

Link: https://bugzilla.redhat.com/show_bug.cgi?id=1639397
Link: https://bugs.lttng.org/issues/1174
Link: https://lore.kernel.org/lkml/[e-mail]

Fixes: e46daee53bb5 ("ARM: 8806/1: kprobes: Fix false positive with FORTIFY_SOURCE")
Signed-off-by: Mathieu Desnoyers <[e-mail]>
Reported-by: Robert Berger <[e-mail]>
Tested-by: Robert Berger <[e-mail]>
Acked-by: Kees Cook <[e-mail]>
Cc: Robert Berger <[e-mail]>
Cc: Masami Hiramatsu <[e-mail]>
Cc: William Cohen <[e-mail]>
Cc: Laura Abbott <[e-mail]>
Cc: Kees Cook <[e-mail]>
Cc: <[e-mail]> # v4.14+
Cc: [e-mail]
Cc: [e-mail]
Signed-off-by: Russell King <[e-mail]>

arch/arm/probes/kprobes/opt-arm.c

···
 	}
 
 	/* Copy arch-dep-instance from template. */
-	memcpy(code, (unsigned char *)optprobe_template_entry,
+	memcpy(code, (unsigned long *)&optprobe_template_entry,
 			TMPL_END_IDX * sizeof(kprobe_opcode_t));
 
 	/* Adjust buffer according to instruction. */