Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

EDAC: Delete unnecessary check before calling pci_dev_put()

The pci_dev_put() function tests whether its argument is NULL and then
returns immediately. Thus the test before the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Link: http://lkml.kernel.org/r/546CB20D.4070808@users.sourceforge.net
[ Boris: commit message. ]
Signed-off-by: Borislav Petkov <bp@suse.de>

authored by

Markus Elfring and committed by
Borislav Petkov
0a98babd 19ca5a3c

+4 -8
+1 -2
drivers/edac/i3000_edac.c
··· 542 542 pci_unregister_driver(&i3000_driver); 543 543 544 544 fail0: 545 - if (mci_pdev) 546 - pci_dev_put(mci_pdev); 545 + pci_dev_put(mci_pdev); 547 546 548 547 return pci_rc; 549 548 }
+1 -2
drivers/edac/i3200_edac.c
··· 523 523 pci_unregister_driver(&i3200_driver); 524 524 525 525 fail0: 526 - if (mci_pdev) 527 - pci_dev_put(mci_pdev); 526 + pci_dev_put(mci_pdev); 528 527 529 528 return pci_rc; 530 529 }
+1 -2
drivers/edac/i82443bxgx_edac.c
··· 458 458 if (!i82443bxgx_registered) 459 459 i82443bxgx_edacmc_remove_one(mci_pdev); 460 460 461 - if (mci_pdev) 462 - pci_dev_put(mci_pdev); 461 + pci_dev_put(mci_pdev); 463 462 } 464 463 465 464 module_init(i82443bxgx_edacmc_init);
+1 -2
drivers/edac/x38_edac.c
··· 500 500 pci_unregister_driver(&x38_driver); 501 501 502 502 fail0: 503 - if (mci_pdev) 504 - pci_dev_put(mci_pdev); 503 + pci_dev_put(mci_pdev); 505 504 506 505 return pci_rc; 507 506 }