Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

drm/pl111: pl111_vexpress.c: Add of_node_put() before return

Each iteration of for_each_available_child_of_node puts the previous
node, but in the case of a break from the middle of the loop there is
no put, thus causing a memory leak. Hence add an of_node_put before the
break.
Issue found with Coccinelle.

Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
Signed-off-by: Eric Anholt <eric@anholt.net>
Link: https://patchwork.freedesktop.org/patch/msgid/20190706132742.3250-1-nishkadg.linux@gmail.com

authored by

Nishka Dasgupta and committed by
Eric Anholt
0a869e8d 71866a56

+1
+1
drivers/gpu/drm/pl111/pl111_vexpress.c
··· 51 51 } 52 52 if (of_device_is_compatible(child, "arm,hdlcd")) { 53 53 has_coretile_hdlcd = true; 54 + of_node_put(child); 54 55 break; 55 56 } 56 57 }