Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

reiserfs: fix "new_insert_key may be used uninitialized ..."

new_insert_key only makes any sense when it's associated with a
new_insert_ptr, which is initialized to NULL and changed to a
buffer_head when we also initialize new_insert_key. We can key off of
that to avoid the uninitialized warning.

Link: http://lkml.kernel.org/r/5eca5ffb-2155-8df2-b4a2-f162f105efed@suse.com
Signed-off-by: Jeff Mahoney <jeffm@suse.com>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Jan Kara <jack@suse.cz>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

authored by

Jeff Mahoney and committed by
Linus Torvalds
0a11b9aa e63e88bc

+2 -1
+2 -1
fs/reiserfs/ibalance.c
··· 1153 1153 insert_ptr); 1154 1154 } 1155 1155 1156 - memcpy(new_insert_key_addr, &new_insert_key, KEY_SIZE); 1157 1156 insert_ptr[0] = new_insert_ptr; 1157 + if (new_insert_ptr) 1158 + memcpy(new_insert_key_addr, &new_insert_key, KEY_SIZE); 1158 1159 1159 1160 return order; 1160 1161 }