Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

cdrom: make unregister_cdrom() return void

Now unregister_cdrom() always returns 0.
Make it return void and update all callers that check the return value.

Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
Cc: Adrian McMenamin <adrian@mcmen.demon.co.uk>
Cc: Borislav Petkov <petkovbb@gmail.com>
Signed-off-by: Jens Axboe <jens.axboe@oracle.com>

authored by

Akinobu Mita and committed by
Jens Axboe
0a0c4114 7fd097d4

+9 -12
+1 -1
Documentation/cdrom/cdrom-standard.tex
··· 777 777 it may have as many structures $<device>_info$ as there are minor devices 778 778 active. $Register_cdrom()$ builds a linked list from these. 779 779 780 - \subsection{$Int\ unregister_cdrom(struct\ cdrom_device_info * cdi)$} 780 + \subsection{$Void\ unregister_cdrom(struct\ cdrom_device_info * cdi)$} 781 781 782 782 Unregistering device $cdi$ with minor number $MINOR(cdi\to dev)$ removes 783 783 the minor device from the list. If it was the last registered minor for
+1 -2
drivers/cdrom/cdrom.c
··· 442 442 } 443 443 #undef ENSURE 444 444 445 - int unregister_cdrom(struct cdrom_device_info *cdi) 445 + void unregister_cdrom(struct cdrom_device_info *cdi) 446 446 { 447 447 cdinfo(CD_OPEN, "entering unregister_cdrom\n"); 448 448 ··· 455 455 456 456 cdi->ops->n_minors--; 457 457 cdinfo(CD_REG_UNREG, "drive \"/dev/%s\" unregistered\n", cdi->name); 458 - return 0; 459 458 } 460 459 461 460 int cdrom_get_media_event(struct cdrom_device_info *cdi,
+3 -1
drivers/cdrom/gdrom.c
··· 827 827 del_gendisk(gd.disk); 828 828 if (gdrom_major) 829 829 unregister_blkdev(gdrom_major, GDROM_DEV_NAME); 830 - return unregister_cdrom(gd.cd_info); 830 + unregister_cdrom(gd.cd_info); 831 + 832 + return 0; 831 833 } 832 834 833 835 static struct platform_driver gdrom_driver = {
+1 -4
drivers/cdrom/viocd.c
··· 650 650 { 651 651 struct disk_info *d = &viocd_diskinfo[vdev->unit_address]; 652 652 653 - if (unregister_cdrom(&d->viocd_info) != 0) 654 - printk(VIOCD_KERN_WARNING 655 - "Cannot unregister viocd CD-ROM %s!\n", 656 - d->viocd_info.name); 653 + unregister_cdrom(&d->viocd_info); 657 654 del_gendisk(d->viocd_disk); 658 655 blk_cleanup_queue(d->viocd_disk->queue); 659 656 put_disk(d->viocd_disk);
+2 -3
drivers/ide/ide-cd.c
··· 2032 2032 2033 2033 kfree(info->buffer); 2034 2034 kfree(info->toc); 2035 - if (devinfo->handle == drive && unregister_cdrom(devinfo)) 2036 - printk(KERN_ERR "%s: %s failed to unregister device from the cdrom " 2037 - "driver.\n", __FUNCTION__, drive->name); 2035 + if (devinfo->handle == drive) 2036 + unregister_cdrom(devinfo); 2038 2037 drive->dsc_overlap = 0; 2039 2038 drive->driver_data = NULL; 2040 2039 blk_queue_prep_rq(drive->queue, NULL);
+1 -1
include/linux/cdrom.h
··· 995 995 extern int cdrom_media_changed(struct cdrom_device_info *); 996 996 997 997 extern int register_cdrom(struct cdrom_device_info *cdi); 998 - extern int unregister_cdrom(struct cdrom_device_info *cdi); 998 + extern void unregister_cdrom(struct cdrom_device_info *cdi); 999 999 1000 1000 typedef struct { 1001 1001 int data;