Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

checkpatch: warn about unexpectedly long msleep's

As explained in Documentation/timers/timers-howto.txt, msleep's of < 20ms
may sleep for as long as 20ms. Caller's of msleep(1) or msleep(2), etc
are likely not to expect this quirky behavior - warn them.

Signed-off-by: Patrick Pannuto <ppannuto@codeaurora.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

authored by

Patrick Pannuto and committed by
Linus Torvalds
09ef8725 1a15a250

+7
+7
scripts/checkpatch.pl
··· 2592 2592 } 2593 2593 } 2594 2594 2595 + # warn about unexpectedly long msleep's 2596 + if ($line =~ /\bmsleep\s*\((\d+)\);/) { 2597 + if ($1 < 20) { 2598 + WARN("msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.txt\n" . $line); 2599 + } 2600 + } 2601 + 2595 2602 # warn about #ifdefs in C files 2596 2603 # if ($line =~ /^.\s*\#\s*if(|n)def/ && ($realfile =~ /\.c$/)) { 2597 2604 # print "#ifdef in C files should be avoided\n";