Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

rtc: tps6594: Fix integer overflow on 32bit systems

The problem is this multiply in tps6594_rtc_set_offset()

tmp = offset * TICKS_PER_HOUR;

The "tmp" variable is an s64 but "offset" is a long in the
(-277774)-277774 range. On 32bit systems a long can hold numbers up to
approximately two billion. The number of TICKS_PER_HOUR is really large,
(32768 * 3600) or roughly a hundred million. When you start multiplying
by a hundred million it doesn't take long to overflow the two billion
mark.

Probably the safest way to fix this is to change the type of
TICKS_PER_HOUR to long long because it's such a large number.

Fixes: 9f67c1e63976 ("rtc: tps6594: Add driver for TPS6594 RTC")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://lore.kernel.org/r/1074175e-5ecb-4e3d-b721-347d794caa90@stanley.mountain
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>

authored by

Dan Carpenter and committed by
Alexandre Belloni
09c4a610 8c28c499

+1 -1
+1 -1
drivers/rtc/rtc-tps6594.c
··· 37 37 #define MAX_OFFSET (277774) 38 38 39 39 // Number of ticks per hour 40 - #define TICKS_PER_HOUR (32768 * 3600) 40 + #define TICKS_PER_HOUR (32768 * 3600LL) 41 41 42 42 // Multiplier for ppb conversions 43 43 #define PPB_MULT NANO