Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

selftests/bpf: Fix check_mtu using wrong variable type

Dan Carpenter found via Smatch static checker, that unsigned 'mtu_lo' is
never less than zero.

Variable mtu_lo should have been an 'int', because read_mtu_device_lo()
uses minus as error indications.

Fixes: b62eba563229 ("selftests/bpf: Tests using bpf_check_mtu BPF-helper")
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: Jesper Dangaard Brouer <brouer@redhat.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
Link: https://lore.kernel.org/bpf/168605104733.3636467.17945947801753092590.stgit@firesoul

authored by

Jesper Dangaard Brouer and committed by
Daniel Borkmann
09564181 aa618270

+1 -1
+1 -1
tools/testing/selftests/bpf/prog_tests/check_mtu.c
··· 183 183 184 184 void serial_test_check_mtu(void) 185 185 { 186 - __u32 mtu_lo; 186 + int mtu_lo; 187 187 188 188 if (test__start_subtest("bpf_check_mtu XDP-attach")) 189 189 test_check_mtu_xdp_attach();