Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

staging: rtl8188eu: Fix null pointer dereference on free_netdev call

An unregister_netdev call checks if pnetdev is null, hence a later
call to free_netdev can potentially be passing a null pointer, causing
a null pointer dereference. Avoid this by adding a null pointer check
on pnetdev before calling free_netdev.

Fixes: 1665c8fdffbb ("staging: rtl8188eu: use netdev routines for private data")
Reviewed-by: Martin Kaiser <martin@kaiser.cx>
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Link: https://lore.kernel.org/r/20210324152135.254152-1-colin.king@canonical.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

authored by

Colin Ian King and committed by
Greg Kroah-Hartman
0933e51a d8827ae8

+2 -1
+2 -1
drivers/staging/rtl8188eu/os_dep/usb_intf.c
··· 446 446 pr_debug("+r871xu_dev_remove, hw_init_completed=%d\n", 447 447 if1->hw_init_completed); 448 448 rtw_free_drv_sw(if1); 449 - free_netdev(pnetdev); 449 + if (pnetdev) 450 + free_netdev(pnetdev); 450 451 } 451 452 452 453 static int rtw_drv_init(struct usb_interface *pusb_intf, const struct usb_device_id *pdid)