Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

ipv4: check optlen for IP_MULTICAST_IF option

Due to man page of setsockopt, if optlen is not valid, kernel should return
-EINVAL. But a simple testcase as following, errno is 0, which means setsockopt
is successful.
addr.s_addr = inet_addr("192.1.2.3");
setsockopt(s, IPPROTO_IP, IP_MULTICAST_IF, &addr, 1);
printf("errno is %d\n", errno);

Xiaotian Feng(dfeng@redhat.com) caught the bug. We fix it firstly checking
the availability of optlen and then dealing with the logic like other options.

Reported-by: Xiaotian Feng <dfeng@redhat.com>
Signed-off-by: Shan Wei <shanwei@cn.fujitsu.com>
Acked-by: Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>
Signed-off-by: David S. Miller <davem@davemloft.net>

authored by

Shan Wei and committed by
David S. Miller
0915921b 8b3f6af8

+3
+3
net/ipv4/ip_sockglue.c
··· 611 611 * Check the arguments are allowable 612 612 */ 613 613 614 + if (optlen < sizeof(struct in_addr)) 615 + goto e_inval; 616 + 614 617 err = -EFAULT; 615 618 if (optlen >= sizeof(struct ip_mreqn)) { 616 619 if (copy_from_user(&mreq, optval, sizeof(mreq)))