Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

serial: sh-sci: Fix out-of-bounds access through DT alias

The sci_ports[] array is indexed using a value derived from the
"serialN" alias in DT, which may lead to an out-of-bounds access.

Fix this by adding a range check.

Note that the array size is defined by a Kconfig symbol
(CONFIG_SERIAL_SH_SCI_NR_UARTS), so this can even be triggered using a
legitimate DTB.

Fixes: 97ed9790c514066b ("serial: sh-sci: Remove unused platform data capabilities field")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

authored by

Geert Uytterhoeven and committed by
Greg Kroah-Hartman
090fa4b0 49ee23b7

+4
+4
drivers/tty/serial/sh-sci.c
··· 3109 3109 dev_err(&pdev->dev, "failed to get alias id (%d)\n", id); 3110 3110 return NULL; 3111 3111 } 3112 + if (id >= ARRAY_SIZE(sci_ports)) { 3113 + dev_err(&pdev->dev, "serial%d out of range\n", id); 3114 + return NULL; 3115 + } 3112 3116 3113 3117 sp = &sci_ports[id]; 3114 3118 *dev_id = id;