Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

ppp: Adjust indentation into ppp_async_input

Clang warns:

../drivers/net/ppp/ppp_async.c:877:6: warning: misleading indentation;
statement is not part of the previous 'if' [-Wmisleading-indentation]
ap->rpkt = skb;
^
../drivers/net/ppp/ppp_async.c:875:5: note: previous statement is here
if (!skb)
^
1 warning generated.

This warning occurs because there is a space before the tab on this
line. Clean up this entire block's indentation so that it is consistent
with the Linux kernel coding style and clang no longer warns.

Fixes: 6722e78c9005 ("[PPP]: handle misaligned accesses")
Link: https://github.com/ClangBuiltLinux/linux/issues/800
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

authored by

Nathan Chancellor and committed by
David S. Miller
08cbc75f 5c61e223

+9 -9
+9 -9
drivers/net/ppp/ppp_async.c
··· 874 874 skb = dev_alloc_skb(ap->mru + PPP_HDRLEN + 2); 875 875 if (!skb) 876 876 goto nomem; 877 - ap->rpkt = skb; 878 - } 879 - if (skb->len == 0) { 880 - /* Try to get the payload 4-byte aligned. 881 - * This should match the 882 - * PPP_ALLSTATIONS/PPP_UI/compressed tests in 883 - * process_input_packet, but we do not have 884 - * enough chars here to test buf[1] and buf[2]. 885 - */ 877 + ap->rpkt = skb; 878 + } 879 + if (skb->len == 0) { 880 + /* Try to get the payload 4-byte aligned. 881 + * This should match the 882 + * PPP_ALLSTATIONS/PPP_UI/compressed tests in 883 + * process_input_packet, but we do not have 884 + * enough chars here to test buf[1] and buf[2]. 885 + */ 886 886 if (buf[0] != PPP_ALLSTATIONS) 887 887 skb_reserve(skb, 2 + (buf[0] & 1)); 888 888 }