Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

net: phy: adin1100: Add interrupt support for link change

An interrupt handler was added to the driver as well as functions
to enable interrupts at the phy.

There are several interrupts maskable at the phy, but only link change
interrupts are handled by the driver yet.

Signed-off-by: Andre Werner <andre.werner@systec-electronic.com>
Link: https://lore.kernel.org/r/20240129135734.18975-3-andre.werner@systec-electronic.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

authored by

Andre Werner and committed by
Jakub Kicinski
08b47dfd 61c81872

+55
+55
drivers/net/phy/adin1100.c
··· 18 18 #define PHY_ID_ADIN1110 0x0283bc91 19 19 #define PHY_ID_ADIN2111 0x0283bca1 20 20 21 + #define ADIN_PHY_SUBSYS_IRQ_MASK 0x0021 22 + #define ADIN_LINK_STAT_CHNG_IRQ_EN BIT(1) 23 + 24 + #define ADIN_PHY_SUBSYS_IRQ_STATUS 0x0011 25 + #define ADIN_LINK_STAT_CHNG BIT(1) 26 + 21 27 #define ADIN_FORCED_MODE 0x8000 22 28 #define ADIN_FORCED_MODE_EN BIT(0) 23 29 ··· 140 134 } 141 135 142 136 return genphy_c45_config_aneg(phydev); 137 + } 138 + 139 + static int adin_phy_ack_intr(struct phy_device *phydev) 140 + { 141 + /* Clear pending interrupts */ 142 + int rc = phy_read_mmd(phydev, MDIO_MMD_VEND2, 143 + ADIN_PHY_SUBSYS_IRQ_STATUS); 144 + 145 + return rc < 0 ? rc : 0; 146 + } 147 + 148 + static int adin_config_intr(struct phy_device *phydev) 149 + { 150 + u16 irq_mask; 151 + int ret; 152 + 153 + ret = adin_phy_ack_intr(phydev); 154 + if (ret) 155 + return ret; 156 + 157 + if (phydev->interrupts == PHY_INTERRUPT_ENABLED) 158 + irq_mask = ADIN_LINK_STAT_CHNG_IRQ_EN; 159 + else 160 + irq_mask = 0; 161 + 162 + return phy_modify_mmd(phydev, MDIO_MMD_VEND2, 163 + ADIN_PHY_SUBSYS_IRQ_MASK, 164 + ADIN_LINK_STAT_CHNG_IRQ_EN, irq_mask); 165 + } 166 + 167 + static irqreturn_t adin_phy_handle_interrupt(struct phy_device *phydev) 168 + { 169 + int irq_status; 170 + 171 + irq_status = phy_read_mmd(phydev, MDIO_MMD_VEND2, 172 + ADIN_PHY_SUBSYS_IRQ_STATUS); 173 + if (irq_status < 0) { 174 + phy_error(phydev); 175 + return IRQ_NONE; 176 + } 177 + 178 + if (!(irq_status & ADIN_LINK_STAT_CHNG)) 179 + return IRQ_NONE; 180 + 181 + phy_trigger_machine(phydev); 182 + 183 + return IRQ_HANDLED; 143 184 } 144 185 145 186 static int adin_set_powerdown_mode(struct phy_device *phydev, bool en) ··· 328 275 .probe = adin_probe, 329 276 .config_aneg = adin_config_aneg, 330 277 .read_status = adin_read_status, 278 + .config_intr = adin_config_intr, 279 + .handle_interrupt = adin_phy_handle_interrupt, 331 280 .set_loopback = adin_set_loopback, 332 281 .suspend = adin_suspend, 333 282 .resume = adin_resume,