Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

iio: adc: Remove redundant dev_err_probe()

There is no need to call the dev_err() function directly to print a custom
message when handling an error from either the platform_get_irq() or
platform_get_irq_byname() functions as both are going to display an
appropriate error message in case of a failure.

Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Acked-by: Heiko Stuebner <heiko@sntech.de>
Link: https://lore.kernel.org/r/20230727073912.4178659-1-ruanjinjie@huawei.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

authored by

Ruan Jinjie and committed by
Jonathan Cameron
089c1e11 1240c94c

+7 -11
+2 -4
drivers/iio/adc/ab8500-gpadc.c
··· 1099 1099 1100 1100 gpadc->irq_sw = platform_get_irq_byname(pdev, "SW_CONV_END"); 1101 1101 if (gpadc->irq_sw < 0) 1102 - return dev_err_probe(dev, gpadc->irq_sw, 1103 - "failed to get platform sw_conv_end irq\n"); 1102 + return gpadc->irq_sw; 1104 1103 1105 1104 if (is_ab8500(gpadc->ab8500)) { 1106 1105 gpadc->irq_hw = platform_get_irq_byname(pdev, "HW_CONV_END"); 1107 1106 if (gpadc->irq_hw < 0) 1108 - return dev_err_probe(dev, gpadc->irq_hw, 1109 - "failed to get platform hw_conv_end irq\n"); 1107 + return gpadc->irq_hw; 1110 1108 } else { 1111 1109 gpadc->irq_hw = 0; 1112 1110 }
+1 -1
drivers/iio/adc/imx7d_adc.c
··· 496 496 497 497 irq = platform_get_irq(pdev, 0); 498 498 if (irq < 0) 499 - return dev_err_probe(dev, irq, "Failed getting irq\n"); 499 + return irq; 500 500 501 501 info->clk = devm_clk_get(dev, "adc"); 502 502 if (IS_ERR(info->clk))
+2 -4
drivers/iio/adc/palmas_gpadc.c
··· 915 915 916 916 adc->irq_auto_0 = platform_get_irq(pdev, 1); 917 917 if (adc->irq_auto_0 < 0) 918 - return dev_err_probe(adc->dev, adc->irq_auto_0, 919 - "get auto0 irq failed\n"); 918 + return adc->irq_auto_0; 920 919 921 920 ret = devm_request_threaded_irq(&pdev->dev, adc->irq_auto_0, NULL, 922 921 palmas_gpadc_irq_auto, IRQF_ONESHOT, ··· 927 928 928 929 adc->irq_auto_1 = platform_get_irq(pdev, 2); 929 930 if (adc->irq_auto_1 < 0) 930 - return dev_err_probe(adc->dev, adc->irq_auto_1, 931 - "get auto1 irq failed\n"); 931 + return adc->irq_auto_1; 932 932 933 933 ret = devm_request_threaded_irq(&pdev->dev, adc->irq_auto_1, NULL, 934 934 palmas_gpadc_irq_auto, IRQF_ONESHOT,
+1 -1
drivers/iio/adc/rockchip_saradc.c
··· 466 466 467 467 irq = platform_get_irq(pdev, 0); 468 468 if (irq < 0) 469 - return dev_err_probe(&pdev->dev, irq, "failed to get irq\n"); 469 + return irq; 470 470 471 471 ret = devm_request_irq(&pdev->dev, irq, rockchip_saradc_isr, 472 472 0, dev_name(&pdev->dev), info);
+1 -1
drivers/iio/light/cm3605.c
··· 227 227 228 228 irq = platform_get_irq(pdev, 0); 229 229 if (irq < 0) { 230 - ret = dev_err_probe(dev, irq, "failed to get irq\n"); 230 + ret = irq; 231 231 goto out_disable_aset; 232 232 } 233 233