Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

i2c: k1: Initialize variable before use

Commit 95a8ca229032 ("i2c: spacemit: add support for SpacemiT K1
SoC") introduced a check in the probe function to warn the user
if the DTS has incorrect frequency settings. In such cases, the
driver falls back to default values.

However, the return value of of_property_read_u32() was not
stored, making the check ineffective. Fix this by storing the
return value in 'ret' and evaluating it properly.

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202503200928.eBWfwnHG-lkp@intel.com/
Cc: Troy Mitchell <troymitchell988@gmail.com>
Link: https://lore.kernel.org/r/20250320113521.3966762-1-andi.shyti@kernel.org
Signed-off-by: Andi Shyti <andi.shyti@kernel.org>

+1 -1
+1 -1
drivers/i2c/busses/i2c-k1.c
··· 514 514 if (!i2c) 515 515 return -ENOMEM; 516 516 517 - of_property_read_u32(of_node, "clock-frequency", &i2c->clock_freq); 517 + ret = of_property_read_u32(of_node, "clock-frequency", &i2c->clock_freq); 518 518 if (ret && ret != -EINVAL) 519 519 dev_warn(dev, "failed to read clock-frequency property: %d\n", ret); 520 520