Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

media: exynos4-is: Fix kernel-doc entries in fimc-is.h

Fixes scripts/kernel-doc warnings:

fimc-is.h:286: warning: Function parameter or member 'fw' not described in 'fimc_is'
fimc-is.h:286: warning: Function parameter or member 'memory' not described in 'fimc_is'
fimc-is.h:286: warning: Function parameter or member 'f_w' not described in 'fimc_is'
fimc-is.h:286: warning: Function parameter or member 'isp' not described in 'fimc_is'
fimc-is.h:286: warning: Function parameter or member 'sensor' not described in 'fimc_is'
fimc-is.h:286: warning: Function parameter or member 'setfile' not described in 'fimc_is'
fimc-is.h:286: warning: Function parameter or member 'ctrl_handler' not described in 'fimc_is'
fimc-is.h:286: warning: Function parameter or member 'irq' not described in 'fimc_is'
fimc-is.h:286: warning: Function parameter or member 'sensor_index' not described in 'fimc_is'
fimc-is.h:286: warning: Function parameter or member 'i2h_cmd' not described in 'fimc_is'
fimc-is.h:286: warning: Function parameter or member 'h2i_cmd' not described in 'fimc_is'
fimc-is.h:286: warning: Function parameter or member 'fd_header' not described in 'fimc_is'
fimc-is.h:286: warning: Function parameter or member 'config' not described in 'fimc_is'
fimc-is.h:286: warning: Function parameter or member 'config_index' not described in 'fimc_is'
fimc-is.h:286: warning: Function parameter or member 'is_p_region' not described in 'fimc_is'
fimc-is.h:286: warning: Function parameter or member 'is_dma_p_region' not described in 'fimc_is'
fimc-is.h:286: warning: Function parameter or member 'is_shared_region' not described in 'fimc_is'
fimc-is.h:286: warning: Function parameter or member 'af' not described in 'fimc_is'
fimc-is.h:286: warning: Function parameter or member 'debugfs_entry' not described in 'fimc_is'

The f_w field is unused so remove it.

Reported-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>

authored by

Sylwester Nawrocki and committed by
Mauro Carvalho Chehab
08874fdd b24bc3ab

+19 -2
+19 -2
drivers/media/platform/exynos4-is/fimc-is.h
··· 232 232 * struct fimc_is - fimc-is data structure 233 233 * @pdev: pointer to FIMC-IS platform device 234 234 * @pctrl: pointer to pinctrl structure for this device 235 - * @v4l2_dev: pointer to top the level v4l2_device 235 + * @v4l2_dev: pointer to the top level v4l2_device 236 + * @fw: data structure describing the FIMC-IS firmware binary 237 + * @memory: memory region assigned for the FIMC-IS (firmware) 238 + * @isp: the ISP block data structure 239 + * @sensor: fimc-is sensor subdevice array 240 + * @setfile: descriptor of the imaging pipeline calibration data 241 + * @ctrl_handler: the v4l2 controls handler 236 242 * @lock: mutex serializing video device and the subdev operations 237 243 * @slock: spinlock protecting this data structure and the hw registers 238 244 * @clocks: FIMC-LITE gate clock 239 245 * @regs: MCUCTL mmapped registers region 240 246 * @pmu_regs: PMU ISP mmapped registers region 247 + * @irq: FIMC-IS interrupt 241 248 * @irq_queue: interrupt handling waitqueue 242 249 * @lpm: low power mode flag 243 250 * @state: internal driver's state flags 251 + * @sensor_index: image sensor index for the firmware 252 + * @i2h_cmd: FIMC-IS to the host (CPU) mailbox command data structure 253 + * @h2i_cmd: the host (CPU) to FIMC-IS mailbox command data structure 254 + * @fd_header: the face detection result data structure 255 + * @config: shared HW pipeline configuration data 256 + * @config_index: index to the @config entry currently in use 257 + * @is_p_region: pointer to the shared parameter memory region 258 + * @is_dma_p_region: DMA address of the shared parameter memory region 259 + * @is_shared_region: pointer to the IS shared region data structure 260 + * @af: auto focus data 261 + * @debugfs_entry: debugfs entry for the firmware log 244 262 */ 245 263 struct fimc_is { 246 264 struct platform_device *pdev; ··· 267 249 268 250 struct fimc_is_firmware fw; 269 251 struct fimc_is_memory memory; 270 - struct firmware *f_w; 271 252 272 253 struct fimc_isp isp; 273 254 struct fimc_is_sensor sensor[FIMC_IS_SENSORS_NUM];