Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

ARM: dts: Use level interrupt for omap4 & 5 wlcore

Commit 572cf7d7b07d ("ARM: dts: Improve omap l4per idling with wlcore edge
sensitive interrupt") changed wlcore interrupts to use edge interrupt based
on what's specified in the wl1835mod.pdf data sheet.

However, there are still cases where we can have lost interrupts as
described in omap_gpio_unidle(). And using a level interrupt instead of edge
interrupt helps as we avoid the check for untriggered GPIO interrupts in
omap_gpio_unidle().

And with commit e6818d29ea15 ("gpio: gpio-omap: configure edge detection
for level IRQs for idle wakeup") GPIOs idle just fine with level interrupts.

Let's change omap4 and 5 wlcore users back to using level interrupt
instead of edge interrupt. Let's not change the others as I've only seen
this on omap4 and 5, probably because the other SoCs don't have l4per idle
independent of the CPUs.

Fixes: 572cf7d7b07d ("ARM: dts: Improve omap l4per idling with wlcore edge sensitive interrupt")
Depends-on: e6818d29ea15 ("gpio: gpio-omap: configure edge detection for level IRQs for idle wakeup")
Cc: Anders Roxell <anders.roxell@linaro.org>
Cc: Eyal Reizer <eyalr@ti.com>
Cc: Guy Mishol <guym@ti.com>
Cc: John Stultz <john.stultz@linaro.org>
Cc: Ulf Hansson <ulf.hansson@linaro.org>
Signed-off-by: Tony Lindgren <tony@atomide.com>

+5 -5
+1 -1
arch/arm/boot/dts/omap4-droid4-xt894.dts
··· 369 369 compatible = "ti,wl1285", "ti,wl1283"; 370 370 reg = <2>; 371 371 /* gpio_100 with gpmc_wait2 pad as wakeirq */ 372 - interrupts-extended = <&gpio4 4 IRQ_TYPE_EDGE_RISING>, 372 + interrupts-extended = <&gpio4 4 IRQ_TYPE_LEVEL_HIGH>, 373 373 <&omap4_pmx_core 0x4e>; 374 374 interrupt-names = "irq", "wakeup"; 375 375 ref-clock-frequency = <26000000>;
+1 -1
arch/arm/boot/dts/omap4-panda-common.dtsi
··· 474 474 compatible = "ti,wl1271"; 475 475 reg = <2>; 476 476 /* gpio_53 with gpmc_ncs3 pad as wakeup */ 477 - interrupts-extended = <&gpio2 21 IRQ_TYPE_EDGE_RISING>, 477 + interrupts-extended = <&gpio2 21 IRQ_TYPE_LEVEL_HIGH>, 478 478 <&omap4_pmx_core 0x3a>; 479 479 interrupt-names = "irq", "wakeup"; 480 480 ref-clock-frequency = <38400000>;
+1 -1
arch/arm/boot/dts/omap4-sdp.dts
··· 512 512 compatible = "ti,wl1281"; 513 513 reg = <2>; 514 514 interrupt-parent = <&gpio1>; 515 - interrupts = <21 IRQ_TYPE_EDGE_RISING>; /* gpio 53 */ 515 + interrupts = <21 IRQ_TYPE_LEVEL_HIGH>; /* gpio 53 */ 516 516 ref-clock-frequency = <26000000>; 517 517 tcxo-clock-frequency = <26000000>; 518 518 };
+1 -1
arch/arm/boot/dts/omap4-var-som-om44-wlan.dtsi
··· 69 69 compatible = "ti,wl1271"; 70 70 reg = <2>; 71 71 interrupt-parent = <&gpio2>; 72 - interrupts = <9 IRQ_TYPE_EDGE_RISING>; /* gpio 41 */ 72 + interrupts = <9 IRQ_TYPE_LEVEL_HIGH>; /* gpio 41 */ 73 73 ref-clock-frequency = <38400000>; 74 74 }; 75 75 };
+1 -1
arch/arm/boot/dts/omap5-board-common.dtsi
··· 362 362 pinctrl-names = "default"; 363 363 pinctrl-0 = <&wlcore_irq_pin>; 364 364 interrupt-parent = <&gpio1>; 365 - interrupts = <14 IRQ_TYPE_EDGE_RISING>; /* gpio 14 */ 365 + interrupts = <14 IRQ_TYPE_LEVEL_HIGH>; /* gpio 14 */ 366 366 ref-clock-frequency = <26000000>; 367 367 }; 368 368 };