Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

Input: gpio_keys - fix leaking DT node references

for_each_available_child_of_node(node, pp) takes reference to 'pp' and
drops it when attempting next iteration. However if we exit the loop early
we need to drop the reference ourselves.

Tested-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

+3
+3
drivers/input/keyboard/gpio_keys.c
··· 659 659 dev_err(dev, 660 660 "Failed to get gpio flags, error: %d\n", 661 661 error); 662 + of_node_put(pp); 662 663 return ERR_PTR(error); 663 664 } 664 665 } else { ··· 670 669 671 670 if (!gpio_is_valid(button->gpio) && !button->irq) { 672 671 dev_err(dev, "Found button without gpios or irqs\n"); 672 + of_node_put(pp); 673 673 return ERR_PTR(-EINVAL); 674 674 } 675 675 676 676 if (of_property_read_u32(pp, "linux,code", &button->code)) { 677 677 dev_err(dev, "Button without keycode: 0x%x\n", 678 678 button->gpio); 679 + of_node_put(pp); 679 680 return ERR_PTR(-EINVAL); 680 681 } 681 682