Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

selftests: forwarding: mirror_gre_flower: Fix test result handling

The global variable RET needs to be initialized before each call to
log_test. This test case sets it once before running the tests, but then
calls log_tests for every individual test. Thus a failure in one of the
tests causes spurious failures in follow-up tests as well.

Fix by moving the initialization of RET from test_all() to
full_test_span_gre_dir_acl(), a function that implements the test.

Signed-off-by: Petr Machata <petrm@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

authored by

Petr Machata and committed by
David S. Miller
084fafe9 2243cad9

+2 -2
+2 -2
tools/testing/selftests/net/forwarding/mirror_gre_flower.sh
··· 81 81 local match_dip=$1; shift 82 82 local what=$1; shift 83 83 84 + RET=0 85 + 84 86 mirror_install $swp1 $direction $tundev \ 85 87 "protocol ip flower $tcflags dst_ip $match_dip" 86 88 fail_test_span_gre_dir $tundev $direction ··· 110 108 111 109 test_all() 112 110 { 113 - RET=0 114 - 115 111 slow_path_trap_install $swp1 ingress 116 112 slow_path_trap_install $swp1 egress 117 113