Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

ipmi: Improve error messages on failed irq enable

When the interrupt enable message returns an error, the messages are
not entirely accurate nor helpful. So improve them.

Signed-off-by: Corey Minyard <cminyard@mvista.com>
Cc: Andy Lutomirski <luto@amacapital.net>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

authored by

Corey Minyard and committed by
Linus Torvalds
0849bfec a5f2b3d6

+10 -6
+10 -6
drivers/char/ipmi/ipmi_si_intf.c
··· 663 663 /* We got the flags from the SMI, now handle them. */ 664 664 smi_info->handlers->get_result(smi_info->si_sm, msg, 4); 665 665 if (msg[2] != 0) { 666 - dev_warn(smi_info->dev, "Could not enable interrupts" 667 - ", failed get, using polled mode.\n"); 666 + dev_warn(smi_info->dev, 667 + "Couldn't get irq info: %x.\n", msg[2]); 668 + dev_warn(smi_info->dev, 669 + "Maybe ok, but ipmi might run very slowly.\n"); 668 670 smi_info->si_state = SI_NORMAL; 669 671 } else { 670 672 msg[0] = (IPMI_NETFN_APP_REQUEST << 2); ··· 687 685 688 686 /* We got the flags from the SMI, now handle them. */ 689 687 smi_info->handlers->get_result(smi_info->si_sm, msg, 4); 690 - if (msg[2] != 0) 691 - dev_warn(smi_info->dev, "Could not enable interrupts" 692 - ", failed set, using polled mode.\n"); 693 - else 688 + if (msg[2] != 0) { 689 + dev_warn(smi_info->dev, 690 + "Couldn't set irq info: %x.\n", msg[2]); 691 + dev_warn(smi_info->dev, 692 + "Maybe ok, but ipmi might run very slowly.\n"); 693 + } else 694 694 smi_info->interrupt_disabled = 0; 695 695 smi_info->si_state = SI_NORMAL; 696 696 break;